avatar button Issue 18 #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alecell
requested changes
Jan 18, 2024
Comment on lines
+19
to
+21
| $image.addEventListener('mouseover', () => ($image.src = imageHover)); | ||
| $image.addEventListener('mouseout', () => ($image.src = imageOriginal)); | ||
| } |
There was a problem hiding this comment.
Pq precisou usar JS e não apenas um CSS?
| .plus { | ||
| padding: 18px; | ||
| border-radius: 9999px; | ||
| border: 1.5px solid #fff; |
There was a problem hiding this comment.
Pixel com ponto flutuante é bad
| @@ -0,0 +1,12 @@ | |||
| .plus { | |||
| padding: 18px; | |||
There was a problem hiding this comment.
Não usar pixel para padding, margin e afins, explico melhor nesse artigo: https://www.linkedin.com/pulse/unidades-css-um-guia-completo-alexandre-gomes/
| import iconHover from './iconHover.svg'; | ||
|
|
||
| const html = ` | ||
| <a href="#" class="avatarButton" data-select="container"> |
There was a problem hiding this comment.
O nome dessa classe não condiz com o BEM https://getbem.com/introduction/
|
|
||
| const html = ` | ||
| <a href="#" class="avatarButton" data-select="container"> | ||
| <img class="plus" data-select="image" src="${icon}" alt="" /> |
There was a problem hiding this comment.
Não nomeie a classe com seu conteudo, no caso icon é melhor que plus pq se o icone mudar a classe ainda faz sentido
|
PR fechado decorrente de inatividade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
Feature
- Issue linked
- Build working correctly
- Tests created
Changelog
N/AVisual evidences 🖼️
-- Normal
--Hover
Checklist