-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 17 - Menu e itens #61
Conversation
This reverts commit 8a3f4fa.
src/home/components/NoPetRegirestedPage/images/no-pet-regirested-page.png
Outdated
Show resolved
Hide resolved
@Alecell lembrar de revisar |
Update feat: add active menu change: order components and other changes - change order components - corrections methods code js for standard eslint - changes css px to rem Change home height to "dvh" - dvh is dynamic and most adaptable and used Update index.js alterações de indentação Update Update Update index.js Update index.js Update index.js Update Update index.scss Update index.scss
…ts (#52) * fix: fix the logical to set placeholder, changed the name of the events * rename the events, fix style sizes, change methods names and functions, add togle method * identation * add EOF
* Criei componente de uoload de imagens * Criei um componente de upload de imagem * Criei um componente de upload de imagem * Criei um componente de upload de imagem * Criei um componente de upload de imagem * feat: Create and adjust the UploadImage component closes #24 * Made some adjustments in UploadImage component * feat: A component to upload images, code with corrections made in code review fic #24 * feat: Made adjustments in the Upload Image component fix #24
* Criado arquivo SCSS de definições de fontes para o projeto. * integração do arquivo de font com o arquivo base * aprimorando os comentários do arquivo font.scss * substituição de mixins por variaveis e implementação da importação das fontes no arquivo index * removedo os espaços em branco * devidas remoções feitas e aguardando resposta do Designer * import correto das fontes * corrigindo os nomes das variáveis * nomenclatura ajustada para camelCase
&__logo-container { | ||
display: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Porque desse none pae ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ele toggla o como o logo é exibido baseado no formato de visualização pra garantir uma centralização correta atravez dos formatos. Ta certinho
&__icons { | ||
display: none; | ||
} | ||
|
||
&__exitmenu { | ||
display: none; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Porque esse none ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esses itens só são visíveis na side-menu na versão mobile, em resoluções superiores eles ficam no componente da navigation, por isso os display:none.
@@ -1,5 +1,3 @@ | |||
@use 'reset-css/sass/reset.scss'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q ISSO PAE ????????????????????????????????
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isso é pra testar no celular?
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remover espaços em branco
width: 100%; | ||
padding: 0; | ||
margin: 0; | ||
display: flex; | ||
flex-direction: column; | ||
justify-content: center; | ||
align-items: flex-start; | ||
gap: 0.8rem; | ||
list-style-type: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seu stylelint ta funcionando?
} | ||
} | ||
|
||
&__itens ul li a{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nunca usar tag pura no css, em termos de manutenção isso da mais trabalho pra quem for mexer nisso. Coloque classes
.side-menu-content { | ||
width: 70%; | ||
|
||
&__itens a { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Não use tag diretamente
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usar pnpm
pra instalar dependencias e remover o package-lock
'placeholder:changed', | ||
'asset:changed', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pensamos ontem, mudar o changed
para o imperativo change
&__logo-container { | ||
display: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ele toggla o como o logo é exibido baseado no formato de visualização pra garantir uma centralização correta atravez dos formatos. Ta certinho
width: 100vw; | ||
height: 100vh; | ||
|
||
height: 100dvh; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why dvh
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esse arquivo veio de outro PR, ele não pode constar como adicionado por vc no seu PR, precisamos ajustar isso
Closes #17
Feature
Criação de componente sidemenu responsivo com nav e content, contendo as funções de abrir/fechar e active.
Bugfix
Description
Cause
Solution
Alteração de height da .home de 100vh para 100dvh.
Changelog
`.home { height: 100vh para 100dvh; } `Visual evidences 🖼️
MENU FECHADO:
MENU ABERTO:
MENU ACTIVE:
Checklist
Additional info
- Foi necessário uma pequena alteração na ordem de montagem dos componentes na index.js da home, no sentido de organizar melhor, pois era necessário selecionar itens de outro componente que estava sendo montado depois, a alteração não modificou em nada na renderização do layout. - As funções foram definidas na index.js da home, por ser necessário a interação entre componentes