Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring & formatting #16

Open
2 of 7 tasks
epicallan opened this issue Mar 21, 2018 · 0 comments
Open
2 of 7 tasks

Code refactoring & formatting #16

epicallan opened this issue Mar 21, 2018 · 0 comments
Assignees

Comments

@epicallan
Copy link
Contributor

epicallan commented Mar 21, 2018

  • switch to typescript -- on going
  • add proper types for everything
  • substitute lodash with ramda
  • Refactor folder structure & names in some cases
  • get rid of closures. They have a performance cost & encourage use of global variables
  • selective imports from dependencies

currently for convenience we have such imports import * as Plottable from 'plottable'; but ideally this should be something like import {Components} as Plottable from 'plottable';. We should only import what we use.

  • break long functions into smaller functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants