Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample data issue #1

Open
Mo0nl19ht opened this issue Aug 16, 2021 · 1 comment
Open

Sample data issue #1

Mo0nl19ht opened this issue Aug 16, 2021 · 1 comment

Comments

@Mo0nl19ht
Copy link

Mo0nl19ht commented Aug 16, 2021

Hi Jaewoo Song

Thank you for make this,
but I got problem for using this

In some sample datas(flights, hotels,...)
If any sentence get 415$ comes with $$flight_search(415$$$flight_search.price_range),
data_process.py recognize $$$ as "outer_split_symbol" not ["dallor sign", "inner_split_symbol"]
So it casuse error
image

Conclusion
Some $ comes before number($415) , others $ comes after number(415$) --> this cause error
I'm not sure this problem is for everyone, It could happen only for me
but I just want to let you know

thank you
From YeWan Moon

@devjwsong
Copy link
Owner

devjwsong commented Aug 16, 2021

Hi Yewan, Thank you for your attention to my project.

As you mentioned, this is caused by the "$" symbol and I'm not sure why I didn't notice this when I pushed before.
Actually I have planned to revise my projects as soon as possible, and this one is not an exception.

I will make the problem fixed soon and after that, I will close this issue.
Thank you for your help again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants