Network fixes #190
Network fixes #190
Conversation
This very same check is present a couple of lines below, so there's no point in repeating it. In any case the check must be done after checking that the pointer is not NULL (which is done below).
Having this structure being 16 bytes long causes net_sendto not to work; setting it to 8 bytes means that we can get rid of a few magic numbers in libogc's code (which actually show that the structure is meant to be 8 bytes only). Changes have been tested on both a real Wii and on Dolphin, using the sockettest and udptest from wii-examples. Fixes: devkitPro#189
|
mind updating the lwip stuff too, if needed? |
It's not needed, but I can update that too, if you want. Though I'd rather be conservative and not risk touching it, if it's not broken :-) |
|
lgtm then. |
Actually, after having a closer look at the code, it looks like I involuntarily updated it as well. :-) I thought that the lwip code was using the definitions from the And to the best of my knowledge, |
Two commits, I suggest to not squash them.
Having this structure being 16 bytes long causes net_sendto not to work; setting it to 8 bytes means that we can get rid of a few magic numbers in libogc's code (which actually show that the structure is meant to be 8 bytes only).
Changes have been tested on both a real Wii and on Dolphin, using the sockettest and udptest from wii-examples.