Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: implement net_select() for the Wii #192

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

mardy
Copy link
Contributor

@mardy mardy commented Feb 11, 2025

poll() is generally more efficient and does not have a limitation on the number of file descriptors, but many libraries and programs out there still use select(), so let's make it easier to port them too.

This has been tested with the "chat" program from SDL_net (this patch, but with the "__wii__" reimplementations using net_poll removed), and it seems to be working fine.

Note: I can add a net_poll() for the GameCube, if someone thinks it's worth it.

poll() is generally more efficient and does not have a limitation on the
number of file descriptors, but many libraries and programs out there
still use select(), so let's make it easier to port them too.
@DacoTaco
Copy link
Member

lgtm

@DacoTaco DacoTaco merged commit 841442b into devkitPro:master Feb 11, 2025
1 check passed
Extrems pushed a commit to emukidid/libogc that referenced this pull request Feb 11, 2025
poll() is generally more efficient and does not have a limitation on the
number of file descriptors, but many libraries and programs out there
still use select(), so let's make it easier to port them too
Extrems pushed a commit to extremscorner/libogc-rice that referenced this pull request Feb 16, 2025
poll() is generally more efficient and does not have a limitation on the
number of file descriptors, but many libraries and programs out there
still use select(), so let's make it easier to port them too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants