Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: refactor code to correctly write to the buffer offsets #194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

console: refactor code to correctly write to the buffer offsets #194

wants to merge 1 commit into from

Conversation

DacoTaco
Copy link
Member

@DacoTaco DacoTaco commented Feb 23, 2025 •
edited
Loading

this was reported to me that the console change from some time ago broke all kind of stuff.
these changes solves it once and for all.

this was tested with the following console parameters :

const u32 startXPos = 70;
const u32 startYPos = 114;
const u32 XSize = 502;
const u32 YSize = 300;

results from CON_Init (CON_Init(xfb, startXPos, startYPos, XSize, YSize, stride );):

Screenshot 2025-02-23 20-53-51

results from CON_InitEx(CON_InitEx(rmode, startXPos, startYPos, XSize, YSize);):

Screenshot 2025-02-23 21-11-10

and in YAWMM :

Screenshot 2025-02-23 20-57-40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WinterMute WinterMute Awaiting requested review from WinterMute

@mtheall mtheall Awaiting requested review from mtheall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DacoTaco