Skip to content

Commit 5faaeaa

Browse files
authored
Dev > Main 브랜치 병합
1. Oauth 테스트는 Dev에서 불가능하므로 Main 브랜치에 병합후 테스트합니다.
2 parents 8b3e456 + b29f538 commit 5faaeaa

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

src/main/java/hs/kr/backend/devpals/domain/user/entity/UserEntity.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,10 @@ public class UserEntity {
7979

8080

8181
// 유저 업데이트
82-
public void updateUserInfo(String nickname, String bio, String github, Boolean beginner,
82+
public void updateUserInfo(String nickname, String bio, Boolean beginner,
8383
List<Long> positionIds, List<Long> skillIds, List<Map<String, Object>> career) {
8484
if (nickname != null) { this.nickname = nickname; }
8585
if (bio != null) { this.bio = bio; }
86-
if (github != null) { this.github = github; }
8786
if (beginner != null) { this.beginner = beginner; }
8887
if (positionIds != null) { this.positionIds = new ArrayList<>(positionIds); }
8988
if (skillIds != null) { this.skillIds = new ArrayList<>(skillIds); }
@@ -122,6 +121,9 @@ public void increaseWarning() {
122121
this.warning++;
123122
}
124123

124+
//github 주소 업데이트
125+
public void updateGithub(String github) {this.github = github;}
126+
125127
//회원가입 유저 정보 저장
126128
public UserEntity(String email, String password, String nickname, Boolean beginner) {
127129
this.email = email;

src/main/java/hs/kr/backend/devpals/domain/user/service/UserProfileService.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ public ResponseEntity<ApiResponse<UserResponse>> userUpdateInfo(String token, Us
9898
user.updateUserInfo(
9999
request.getNickname(),
100100
request.getBio(),
101-
request.getGithub(),
102101
request.getBeginner(),
103102
positionIds,
104103
skillIds,

src/main/java/hs/kr/backend/devpals/infra/oauth2/CustomOauth2UserService.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,14 @@ public OAuth2User loadUser(OAuth2UserRequest userRequest) {
4242
}
4343

4444
UserEntity user = userRepository.findByEmail(email)
45-
.orElseGet(() -> userRepository.save(new UserEntity(email, "SOCIAL_LOGIN_USER", name, true)));
45+
.orElseGet(() -> new UserEntity(email, "SOCIAL_LOGIN_USER", name, true));
46+
47+
if ("github".equals(provider)) {
48+
String githubUrl = oAuth2User.getAttribute("html_url");
49+
user.updateGithub(githubUrl);
50+
}
51+
userRepository.save(user);
4652

47-
// attributes에 email이 없는 경우 추가해줌 (DefaultOAuth2User 생성시 필요)
4853
Map<String, Object> attributesMap = new java.util.HashMap<>(oAuth2User.getAttributes());
4954
attributesMap.put("email", email);
5055

0 commit comments

Comments
 (0)