Skip to content

Commit 72a77ca

Browse files
Merge pull request #46 from devpalsPlus/Dev
Dev
2 parents 90d8cdd + e04331a commit 72a77ca

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

src/main/java/hs/kr/backend/devpals/domain/user/repository/AlarmRepository.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ public interface AlarmRepository extends JpaRepository<AlarmEntity, Long> {
2020
Optional<AlarmEntity> findByReceiverIdAndAlarmId(@Param("receiverId") Long receiverId, @Param("alarmId") Long alarmId);
2121

2222
@Modifying
23-
@Query("DELETE FROM AlarmEntity a WHERE a.createdAt < :threshold AND TYPE(a) <> ApplicantAlarmEntity")
23+
@Query("DELETE FROM AlarmEntity a WHERE a.createdAt < :threshold")
2424
void deleteAllOlderThanExceptApplied(@Param("threshold") LocalDateTime threshold);
2525

26-
@Query("SELECT DISTINCT a.receiver.id FROM AlarmEntity a WHERE a.createdAt < :date AND TYPE(a) <> ApplicantAlarmEntity")
26+
@Query("SELECT DISTINCT a.receiver.id FROM AlarmEntity a WHERE a.createdAt < :date")
2727
List<Long> findUserIdsWithAlarmsOlderThan(@Param("date") LocalDateTime date);
2828

2929
}

src/main/java/hs/kr/backend/devpals/domain/user/service/UserAlarmService.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,7 @@ public ResponseEntity<ApiResponse<String>> deleteAlarm(String token, Long alarmI
9898
Long userId = jwtTokenValidator.getUserId(token);
9999
AlarmEntity alarmEntity
100100
= alarmRepository.findByReceiverIdAndAlarmId(userId, alarmId).orElseThrow(() -> new CustomException(ErrorException.ALARM_NOT_FOUND));
101-
if(alarmEntity.getAlarmFilterIntValue().equals(AlarmFilter.APPLIED_PROJECTS.getValue()))
102-
throw new CustomException(ErrorException.CAN_NOT_DELETE_ALARM);
101+
103102
alarmRepository.delete(alarmEntity);
104103

105104
refreshCacheUserAlarm(userId);

src/main/java/hs/kr/backend/devpals/global/common/enums/ReplierFilter.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ public enum ReplierFilter {
2929
this.value = value;
3030
}
3131

32-
@JsonValue
33-
public String getDisplayName() {
34-
return displayName;
35-
}
3632
@JsonValue
3733
public Integer getValue() {
3834
return value;

0 commit comments

Comments
 (0)