Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up: window.intercomSettings #502

Open
devrnt opened this issue Jun 27, 2022 · 1 comment
Open

Follow up: window.intercomSettings #502

devrnt opened this issue Jun 27, 2022 · 1 comment
Assignees
@devrnt

Comments

@devrnt
Copy link
Owner

devrnt commented Jun 27, 2022

It seems like window.intercomSettings isn't used in SPAs, according to #481 (comment). This is confirmed by someone from Intercom. We should follow this up and check for updated documentation, so we can remove the use window.intercomSettings uses in this codebase
@devrnt devrnt self-assigned this Jun 27, 2022
@devrnt
Copy link
Owner Author

devrnt commented Jun 27, 2022

Also note that in both boot and update the "old" window.intercomSettings are spread into the new window.intercomSettings. So by removing the use of these global settings, we should introduce our own global settings reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devrnt devrnt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devrnt