Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Bitcoin Core's list of example implementations #9

Closed
msgilligan opened this issue Sep 22, 2015 · 14 comments · Fixed by bitcoin/bitcoin#6721
Closed

Add to Bitcoin Core's list of example implementations #9

msgilligan opened this issue Sep 22, 2015 · 14 comments · Fixed by bitcoin/bitcoin#6721

Comments

@msgilligan
Copy link
Collaborator

java-libbitcoinconsensus should be listed on doc/shared-libraries.md in Bitcoin Core.

@dexX7
Copy link
Owner

dexX7 commented Sep 23, 2015

Sure, but do you think it's ready?

@msgilligan
Copy link
Collaborator Author

It's ready to be an example implementation. ;) It's ready for people to start using/testing, isn't it? We can put any disclaimers we want on the project page (about being alpha, pre-alpha, etc.), but I would think we should make the project easy to find for those looking for a Java implementation. That way they can use it, report bugs and submit patches as necessary, rather than start a parallel implementation.

We should also announce it on the bitcoinj mailing list. I can send the message if you don't want to do it yourself.

@msgilligan
Copy link
Collaborator Author

Congrats, @dexX7 !

@msgilligan
Copy link
Collaborator Author

Do you want to announce it on the bitcoinj mailing list, or should I?

@dexX7
Copy link
Owner

dexX7 commented Sep 25, 2015

Thanks, @msgilligan! Please go ahead with the mailing list post, if I'd like to. :)

@dexX7 dexX7 closed this as completed Sep 25, 2015
@msgilligan
Copy link
Collaborator Author

if I'd like to.

@dexX7 I'm not sure what you mean by the above.

@dexX7
Copy link
Owner

dexX7 commented Sep 25, 2015

Ahh, sorry, ... I meant "you" of course! :)

It would be great, if you could post on the BitcoinJ mailing list, but only if you want to. :)

@msgilligan
Copy link
Collaborator Author

I want to. I had asked about it earlier, so I feel obligated to let people know. I'd also like to see some users and contributors :)

@dexX7
Copy link
Owner

dexX7 commented Sep 25, 2015

Nice! Over the weekend I'm probably going to take a closer look at setting up Bintray.

@msgilligan
Copy link
Collaborator Author

You can definitely look at the Gradle scripts in OmniJ or bitcoinj-addons. Feel free to ask any questions or, if you'd like, I could even put together a PR.

@dexX7
Copy link
Owner

dexX7 commented Sep 26, 2015

Thanks, help would be very appreciated! I was thinking about publishing to Bintray every release tag, and ideally the Groovy/JavaDoc would be published (e.g. to AWS S3), too. It looks like could be automated via Travis (see #12 (comment)), but I haven't tested it yet. I'd later try to tackle it by creating a dummy/test repo and see how/if it works, but doing it manually would already be a step forward. :)

@msgilligan
Copy link
Collaborator Author

I'll set up the Gradle scripts for (manual) Bintray publishing this weekend.

Autopublishing to Bintray on a release tag is a great idea. I'd like to learn how to do it from Travis and/or Jenkins.

I would recommend publishing to Github pages over AWS S3 because it's free.

@msgilligan
Copy link
Collaborator Author

I sent a low-key announcement to the bitcoinj mailing list just now: https://groups.google.com/d/topic/bitcoinj/oZgCyo7UX2g/discussion

@dexX7
Copy link
Owner

dexX7 commented Sep 29, 2015

Thanks @msgilligan, very appreciated!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants