Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIT step size adjustment #1811

Open
rogerclarkmelbourne opened this issue Oct 25, 2019 · 2 comments
Open

RIT step size adjustment #1811

rogerclarkmelbourne opened this issue Oct 25, 2019 · 2 comments

Comments

@rogerclarkmelbourne
Copy link

This is a feature request which I would like to implement, but would like some feedback before I start implementing it.

A friend of mine finds the RIT step size of 20Hz a bit too course when using CW and would like a lower setting.

I looked in the code and i can see that its hard coded to a step size of 20 and there is also a max number of steps.

tune_freq += (ts.rit_value*20); // Add RIT on receive

return baseval + (ts.rit_value*20);

#define MIN_RIT_VALUE -60 // Minimum RIT Value -1.2 kHz
#define MAX_RIT_VALUE 60 // Maximum RIT Value +1.2 kHz

So potentially all of these would need to be changed.

However, 10Hz or less step size for RIT may be too fine for other modes, and perhaps it would be better if this was implemented as a setting.

And if its a setting, then perhaps the setting should be per mode, i.e a different setting for CW to SSB, AM and DV. (LSB and USB etc would just be grouped as the SSB setting)

I have not looked at the way that the settings are handled, but hopefully i could add a new group of settings and also add something into the UI to allow the setting to be adjusted.

@db4ple
Copy link
Collaborator

db4ple commented Oct 26, 2019

Adding configuration settings controlled via menu is relatively straight forward:

ui_menu.c / ui_menu_structure.c

And for persistent storage use: ui_configuration.h/.c
It is possible to store 2 8bit values in a single config value record (or one 8/16/(32) bit value.)

@rogerclarkmelbourne
Copy link
Author

Thanks.
I already recompiled with 10Hz step size and limit of +/- 99 steps

I will look at the menu and storage for this,

Also. Control could perhaps somehow be via press on RIT encoder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants