You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While using your library, I noticed there was no way to specify a suffix ( custom numbering per say ) and we have to rely on the the rule that the code automatically appends a number ( sitemap1.xml) when the number of urls exceed a certain max. In the sitemaoGeneratorOptions, just like you have an option to specify a suffix, if we have a way to add a special string pattern suffix which can be customized per need and suffices can be turned on or off using a flag, it serves the purpose a bit better for how you want the numbering to work for sitemaps.
I cloned your repo, and made the change locally, and then tried to push my branch to your repo, so I can submit a PR, but I run into permissions issue. Please let me know what is the right way to approach this, or grant permissions to submit PR, so you can review the change I am proposing.
A quick response is highly appreciated!
Thanks a bunch!
Ankita.
The text was updated successfully, but these errors were encountered:
No permissions are required to submit a PR; several folks have done it already without issue. It's possible that instead of trying to push to your own fork, you're trying to push directly to the dfabulich/sitemapgen4j repo, which isn't allowed.
Instead, you push to your own anellimarla/sitemapgen4j fork, and then create a pull request.
Hi,
While using your library, I noticed there was no way to specify a suffix ( custom numbering per say ) and we have to rely on the the rule that the code automatically appends a number ( sitemap1.xml) when the number of urls exceed a certain max. In the sitemaoGeneratorOptions, just like you have an option to specify a suffix, if we have a way to add a special string pattern suffix which can be customized per need and suffices can be turned on or off using a flag, it serves the purpose a bit better for how you want the numbering to work for sitemaps.
I cloned your repo, and made the change locally, and then tried to push my branch to your repo, so I can submit a PR, but I run into permissions issue. Please let me know what is the right way to approach this, or grant permissions to submit PR, so you can review the change I am proposing.
A quick response is highly appreciated!
Thanks a bunch!
Ankita.
The text was updated successfully, but these errors were encountered: