Repository navigation
feat: add typescript support - #14
kylerjensen wants to merge 1 commit into
Conversation
|
Wow, thanks for the quick PR. Looks solid! Unfortunately it seems like this upgrade broke something. Here's how to reproduce. I made this repo back then to be able to play with Steps:Tests will probably fail now due to differences of our laptops, so press u once to update them. This will be the base of comparison now. You can commit the updated tests locally, so you see the real diff after switching the library your version later on. In the TypeScript version of Now back in the The tests will fail now, but they should pass as nothing should change by switching to the TypeScript version. Open Can you look into that? |
Closes #13
As requested, here is a PR that re-writes the module in typescript. I ran into a couple of notable issues:
connectlibrary,serveStaticandfinalhandler. Resolved the issue by switching toexpressand removingfinalhandler(I believe express incorporates finalhandler automatically).Thanks!