Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motoko Base gives warnings on DFX deploy. #610

Open
tiagoicp opened this issue Jan 19, 2024 · 2 comments
Open

Motoko Base gives warnings on DFX deploy. #610

tiagoicp opened this issue Jan 19, 2024 · 2 comments

Comments

@tiagoicp
Copy link

Hi,

It seems two added functions are causing warnings, today upgraded to latest version of both dfx (motoko) and base and I can't do anything to solve these warnings.
Screenshot 2024-01-19 at 11 33 28

One seems to be related with an ongoing discussion: #598
Tagging @kentosugama due to last change, and @timohanke and @ottodevs due to be the participants of the discussion.

The other seems to be related with this recent addition: be273ff
Tagging @ZenVoich and @rvanasa due to being involved with that commit.

Kindly let me know if it's possible to fix 🙏 Thanks

@rvanasa
Copy link
Contributor

rvanasa commented Jan 19, 2024

Thanks for pointing this out! I opened a PR to fix the Array.take() warning for the next base library release. I'll also bring the other warning message to the attention of the team in case we can roll out a fix for this as well.

@Gekctek
Copy link

Gekctek commented Feb 8, 2024

I now updated to 0.10.4 and also get a flood of these warnings.

rvanasa added a commit that referenced this issue Feb 21, 2024
Fixes one of the compiler warnings mentioned in #610.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants