Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up: Array to buffer as Buffer.fromArray, (not Array.buffer). #389

Merged
merged 9 commits into from
Jun 17, 2022
Merged

Clean up: Array to buffer as Buffer.fromArray, (not Array.buffer). #389

merged 9 commits into from
Jun 17, 2022

Conversation

matthewhammer
Copy link
Contributor

@matthewhammer matthewhammer commented Jun 15, 2022 •
edited
Loading

As per the discussion with @crusso and @rossberg, Array to buffer should be Buffer.fromArray, not Array.buffer, as was just merged.

Related:

@matthewhammer matthewhammer mentioned this pull request Jun 15, 2022
Open
@matthewhammer matthewhammer marked this pull request as ready for review June 15, 2022 12:57
@matthewhammer matthewhammer mentioned this pull request Jun 15, 2022
Merged
crusso
crusso reviewed Jun 15, 2022
View reviewed changes
src/Buffer.mo Outdated Show resolved Hide resolved
crusso
crusso requested changes Jun 15, 2022
View reviewed changes
src/Buffer.mo Outdated Show resolved Hide resolved
@matthewhammer
Copy link
Contributor Author

@crusso PTAL

@matthewhammer matthewhammer enabled auto-merge (squash) June 16, 2022 03:19
crusso
crusso requested changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, one more iteration - I mistakenly thought the existing toVarArray was called toArrayMut. We are inconsistent in the libs.... but I guess should at least be consistent within the one file.

src/Buffer.mo Outdated Show resolved Hide resolved
test/bufTest.mo Outdated Show resolved Hide resolved
matthewhammer and others added 2 commits June 17, 2022 08:44
@matthewhammer @crusso
Update src/Buffer.mo
dd3e0d1 
Co-authored-by: Claudio Russo <[email protected]>
@matthewhammer @crusso
Update test/bufTest.mo
6602795 
Co-authored-by: Claudio Russo <[email protected]>
@matthewhammer
Copy link
Contributor Author

matthewhammer commented Jun 17, 2022 •
edited
Loading

We are inconsistent in the libs.

Created #391

@matthewhammer matthewhammer merged commit 7ca5b2c into master Jun 17, 2022
@matthewhammer matthewhammer deleted the array-to-buffer branch June 17, 2022 14:49
@matthewhammer matthewhammer mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso crusso approved these changes

@ggreif ggreif Awaiting requested review from ggreif

@rossberg rossberg Awaiting requested review from rossberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewhammer @crusso