regions: refactor for 64-bit region ids, dropping region table #4176
Merged
crusso merged 13 commits intomultiple-stable-memoryfrom Aug 23, 2023
Merged
regions: refactor for 64-bit region ids, dropping region table #4176crusso merged 13 commits intomultiple-stable-memoryfrom
crusso merged 13 commits intomultiple-stable-memoryfrom
Conversation
crusso
commented
Aug 18, 2023
…ts and update test output; reduce overhead from 9 to 6 pages
crusso
changed the title
luc-blaeser
reviewed
Aug 22, 2023
luc-blaeser
reviewed
Aug 22, 2023
luc-blaeser
reviewed
Aug 22, 2023
luc-blaeser
reviewed
Aug 22, 2023
luc-blaeser
reviewed
Aug 22, 2023
luc-blaeser
reviewed
Aug 22, 2023
luc-blaeser
reviewed
Aug 22, 2023
luc-blaeser
approved these changes
Aug 22, 2023
Contributor
luc-blaeser
left a comment
luc-blaeser
left a comment
There was a problem hiding this comment.
Looks very good. Not having to recycle region IDs simplifies a lot.
Co-authored-by: Luc Blaeser <112870813+luc-blaeser@users.noreply.github.com>
Contributor
|
|
Co-authored-by: Luc Blaeser <112870813+luc-blaeser@users.noreply.github.com>
Contributor
|
|
Contributor
|
|
Contributor
|
|
Contributor
Author
|
@luc-blaeser PTAL |
luc-blaeser
reviewed
Aug 23, 2023
luc-blaeser
reviewed
Aug 23, 2023
luc-blaeser
reviewed
Aug 23, 2023
luc-blaeser
approved these changes
Aug 23, 2023
Contributor
luc-blaeser
left a comment
luc-blaeser
left a comment
There was a problem hiding this comment.
Very nice. Also the recent changes look good.
Co-authored-by: Luc Blaeser <112870813+luc-blaeser@users.noreply.github.com>
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #3768.
With future GC in mind, use inexhaustible 64-bit region id, and drop dense region table, instead encoding size per block, not region, as partial, block level page counts. Regions can be recovered from the sparse representation in the block table.
Region recovery now does two linear scans of block table to recover region page_count followed by block recovery.
Actually metadata memory overhead from 9 to 6 pages, by removing 12 (8 byte pagecount + 4 reserve) bytes per region entry but adding 7 = (64-bit region id + 1 byte size) bytes per block entry.