-
Notifications
You must be signed in to change notification settings - Fork 118
chore: test the core library in nightly run
#5317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 46 commits
63bba0b
1ac6c84
c26d74d
992c86d
94882c7
dceb668
7cb71ac
fa86494
26b71ff
654d390
7424ff5
9229714
9567c08
6515195
8a4b6a1
ea72a79
30d0338
bf15713
c5ec886
f5e6584
d5aee7a
3f23065
48cce4e
3989cff
e55d335
d8a0e38
badd556
b36b32b
bade76c
2341f9d
8810dca
00d2aba
58af100
d70f30a
f76ca03
92c134d
95bc34e
62073a5
a911ecc
2faa27b
c6fa96f
3201cf1
19dc617
6b3d309
1ce2a00
280ead0
a42898f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -47,8 +47,46 @@ jobs: | |||||
| test-name: macos-13-${{ matrix.build_type }}-tests | ||||||
| cachix-auth-token: ${{ secrets.CACHIX_AUTH_TOKEN }} | ||||||
|
|
||||||
| motoko-core-tests: | ||||||
| needs: systems-go-tests | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - name: Get `motoko` Repo | ||||||
| uses: actions/checkout@v4 | ||||||
| - name: Populate `moc` | ||||||
| uses: ./.github/actions/test-blueprint | ||||||
| with: | ||||||
| os: ubuntu-latest | ||||||
| test-target: moc | ||||||
| test-name: fetch-moc | ||||||
| cachix-auth-token: ${{ secrets.CACHIX_AUTH_TOKEN }} | ||||||
| - name: Build `moc` | ||||||
| run: | | ||||||
| nix build .#moc --print-out-paths | ||||||
| - name: Save the `test-blueprint` action | ||||||
| run: cp -r ./.github/actions/test-blueprint .. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not super clear to me: why do we need to copy the blueprint somewhere else?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because the checkout of
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oooh, I see -- can you please add a comment here as well about it so we don't break it some time later when we refactor?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
| - name: Get `motoko-core` Repo | ||||||
| uses: actions/checkout@v4 | ||||||
| with: | ||||||
| repository: dfinity/motoko-core | ||||||
| fetch-depth: "0" | ||||||
| - name: Restore the `test-blueprint` action | ||||||
| run: mv ../test-blueprint ./.github/actions | ||||||
| - name: Set up `mops` | ||||||
| uses: dfinity/motoko-core/.github/actions/setup@main | ||||||
| - name: Set up `mops` cache | ||||||
| run: | | ||||||
| npx ic-mops --version | ||||||
| npx ${DFX_MOC_PATH} --version | ||||||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This runs |
||||||
| - name: Fixup `mops` cache | ||||||
| run: | | ||||||
| ln -sf /nix/store/*-moc/bin/moc $(cat .mops/moc-*) | ||||||
| npx ${DFX_MOC_PATH} --version | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See above suggestion:
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, turns out I need
|
||||||
| - name: Run `motoko-core` Tests | ||||||
| run: npm test | ||||||
|
|
||||||
| create-issue: | ||||||
| needs: [common-tests, gc-tests, systems-go-tests] | ||||||
| needs: [common-tests, gc-tests, systems-go-tests, motoko-core-tests] | ||||||
| if: ${{ always() && contains(needs.*.result, 'failure') }} | ||||||
| runs-on: ubuntu-latest # No need to run on macOS-13, the ubuntu runner should be cheaper to run. | ||||||
| steps: | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -162,10 +162,10 @@ | |
| matchRelease == null && | ||
| matchGC == null; | ||
| in { | ||
| "debug" = matchDebug != null; | ||
| "release" = matchRelease != null; | ||
| "gc" = matchGC != null; | ||
| "common" = matchCommon; | ||
| debug = matchDebug != null; | ||
| release = matchRelease != null; | ||
| gc = matchGC != null; | ||
| common = matchCommon; | ||
| }.${type}) | ||
| tests); | ||
|
|
||
|
|
@@ -208,8 +208,8 @@ | |
| in | ||
| { | ||
| packages = checks // common-constituents // rec { | ||
| "release" = buildableReleaseMoPackages; | ||
| "debug" = buildableDebugMoPackages; | ||
| release = buildableReleaseMoPackages; | ||
| debug = buildableDebugMoPackages; | ||
|
|
||
| inherit nix-update tests js; | ||
|
|
||
|
|
@@ -255,6 +255,8 @@ | |
| ++ builtins.attrValues js; | ||
| }; | ||
|
|
||
| inherit (debug) moc; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. single relevant addition, needed by |
||
|
|
||
| default = release-systems-go; | ||
| }; | ||
|
|
||
|
|
||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cheapest...