Skip to content

Commit c03e41a

Browse files
authored
fix: add browser warning message (#4048)
1 parent 79de1d0 commit c03e41a

9 files changed

Lines changed: 38 additions & 0 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
# UNRELEASED
44

5+
### fix: template frontends now have unsupported browser warnings
6+
7+
DFX's default security headers cause Safari to break when viewing local canisters. Warning messages
8+
have been added to the frontend project templates when the page is broken that indicate to try switching
9+
browsers.
10+
511
### feat: impersonating sender of requests to a local PocketIC instance
612

713
`dfx canister call`, `dfx canister status`, and `dfx canister update-settings` take

‎src/dfx/assets/project_templates/react/src/__frontend_name__/index.html‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010
</head>
1111

1212
<body>
13+
<div class="browser-warning">
14+
⚠️ If this page appears broken, try reloading. If the problem persists, try switching browsers; Chrome or
15+
Firefox are recommended.
16+
</div>
1317
<div id="root"></div>
1418
<script type="module" src="/src/main.jsx"></script>
1519
</body>

‎src/dfx/assets/project_templates/react/src/__frontend_name__/src/index.scss‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,7 @@ button[type="submit"] {
3535
#greeting:empty {
3636
display: none;
3737
}
38+
39+
.browser-warning {
40+
display: none;
41+
}

‎src/dfx/assets/project_templates/svelte/src/__frontend_name__/src/app.html‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010
</head>
1111

1212
<body data-sveltekit-preload-data="hover">
13+
<div class="browser-warning">
14+
⚠️ If this page appears broken, try reloading. If the problem persists, try switching browsers; Chrome or
15+
Firefox are recommended.
16+
</div>
1317
<div style="display: contents">%sveltekit.body%</div>
1418
</body>
1519

‎src/dfx/assets/project_templates/svelte/src/__frontend_name__/src/index.scss‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,7 @@ button[type="submit"] {
3535
#greeting:empty {
3636
display: none;
3737
}
38+
39+
.browser-warning {
40+
display: none;
41+
}

‎src/dfx/assets/project_templates/vanilla_js/src/__frontend_name__/index.html‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@
99
</head>
1010

1111
<body>
12+
<div class="browser-warning">
13+
⚠️ If this page appears broken, try reloading. If the problem persists, try switching browsers; Chrome or
14+
Firefox are recommended.
15+
</div>
1216
<div id="root"></div>
1317
<script type="module" src="/src/main.js"></script>
1418
</body>

‎src/dfx/assets/project_templates/vanilla_js/src/__frontend_name__/src/index.scss‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,7 @@ button[type="submit"] {
3535
#greeting:empty {
3636
display: none;
3737
}
38+
39+
.browser-warning {
40+
display: none;
41+
}

‎src/dfx/assets/project_templates/vue/src/__frontend_name__/index.html‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414
<strong>We're sorry but this application doesn't work properly without
1515
JavaScript enabled. Please enable it to continue.</strong>
1616
</noscript>
17+
<div class="browser-warning">
18+
⚠️ If this page appears broken, try reloading. If the problem persists, try switching browsers; Chrome or
19+
Firefox are recommended.
20+
</div>
1721
<div id="app"></div>
1822
<script src="/src/main.js" type="module"></script>
1923
</body>

‎src/dfx/assets/project_templates/vue/src/__frontend_name__/src/index.scss‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,7 @@ button[type="submit"] {
3535
#greeting:empty {
3636
display: none;
3737
}
38+
39+
.browser-warning {
40+
display: none;
41+
}

0 commit comments

Comments
 (0)