Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server does not tolerate attributes string without spaces #7

Open
zackangelo opened this issue Jul 23, 2015 · 0 comments
Open

Server does not tolerate attributes string without spaces #7

zackangelo opened this issue Jul 23, 2015 · 0 comments

Comments

@zackangelo
Copy link

Exploding on ', ' requires a space in the attribute string (https://github.com/dflydev/dflydev-hawk/tree/master/src/Dflydev/Hawk/Header/HeaderParser.php#L15) which deviates from the regex used in the official HAWK implementation (https://github.com/hueniverse/hawk/blob/master/lib/utils.js#L125).

Maybe switch to splitting on , and doing a trim()?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zackangelo