Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect period guess from exofop #101

Open
avivajpeyi opened this issue Sep 23, 2021 · 10 comments
Open

incorrect period guess from exofop #101

avivajpeyi opened this issue Sep 23, 2021 · 10 comments
Labels
bug 🐛 Something isn't working

Comments

@avivajpeyi
Copy link
Collaborator

avivajpeyi commented Sep 23, 2021

EG TOI 1982

raw data init fit phase
raw data init fit phase
  • from the left most plot, it looks like there is only one transit bw 2323-2325 days
  • could there be another exoplanet in the data?
@avivajpeyi
Copy link
Collaborator Author

This looks like a system with data for only a single transit

#29

@avivajpeyi
Copy link
Collaborator Author

Add 2180 as a TOI to test

@avivajpeyi
Copy link
Collaborator Author

avivajpeyi commented Nov 18, 2021

The third looks like an initialization problem. I'd say that the initial guess for the period is wrong. Can you double check the non-folded version to make sure that it makes sense?

Yeah dan was right about the initial period being off -- I think we are estimating a shorter period than it actually is.

See if the same error occurs for 2180

@avivajpeyi
Copy link
Collaborator Author

avivajpeyi commented Nov 18, 2021

TOI Period (days) Epoch (TBJD) Depth (ppt) Duration (days) Single Transit
1982.01 8.58635 1602.58 5.26 0.222833 False
2180.01 0 1830.79 2.4 1.30892 True

Regarding TOI 1982

  • period guess of 8 days is wrong (cant see transits in 8 day periods)
  • incorrectly labelled as "not a single transit system" our single-transit check uses the period (incorrect here) and data available

Regarding TOI 2180

  • correctly labelled as a single-transit system
  • do not have a period guess: causes issue with our single-transit section of the PE model (fails the testpoint check)
    (made note of this in Single Transits #29 )

@avivajpeyi
Copy link
Collaborator Author

@dfm -- what should we do in the case where SPOC's initial fits may be off?

Data for TOI 1982:
https://exofop.ipac.caltech.edu/tess/target.php?id=437329044

Because the period ~8 we have marked this as a system with multiple transits in the data, and accordingly set our priors:

iTerm2 QmkRd8 priors

@avivajpeyi
Copy link
Collaborator Author

avivajpeyi commented Nov 21, 2021

Another TOI (TOI 2148) with an incorrect initial guess:

ExoFOP page suggests a period of 23 days

flux_vs_time
flux_vs_time

This SPOC fit may have been made during the 1st time this TOI was observed! See old plot when there was just data for ~25 days. Here a period of around 23 is resonable
Screen Shot 2021-11-21 at 8 51 28 pm

@avivajpeyi avivajpeyi changed the title TOI 1982: initialisation problem? Period is off Initial guess for period invalid Nov 21, 2021
@avivajpeyi
Copy link
Collaborator Author

Some follow-up suggestions on how to deal with this documented here: https://github.com/dfm/tess-atlas/wiki/Nov-24,-'21

What do we do when we have the wrong initial guess?

  • Test: quality of fit for odd and even eclipses
  • Even number and odd number eclipses
  • At MAP value -- are later eclipses much worse fit?
  • If 20sig outliers -- something probably off
  • We can do this with the MAP value (before PE)

@avivajpeyi
Copy link
Collaborator Author

  • find more clear examples of this issue

@avivajpeyi
Copy link
Collaborator Author

Another example: TOI 1134

  • SPOC page
  • No initial period provided (updated Oct '21)--> thus we assume it is a single-transit system
  • looking at the data, there are 4 transits

Screen Shot 2022-06-01 at 11 51 55 am

  • Even though our analysis' priors + initial guess are way off, the posterior productive plot looks reasonable:

Screen Shot 2022-06-01 at 2 28 06 pm

  • Our GP 'masks' out the other 3 transits (below we zoom into the 2nd half of the data after the gap)

Screen Shot 2022-06-01 at 2 33 27 pm

@avivajpeyi avivajpeyi changed the title Initial guess for period invalid incorrect period guess from exofop Jun 23, 2022
@avivajpeyi
Copy link
Collaborator Author

Looks like this might still be an issue!
http://catalog.tess-atlas.cloud.edu.au/content/toi_notebooks/toi_1982.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant