-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colorization #18
Comments
Yes, I think that'd be a great enhancement. Does puget have integration
|
hi. is there any way of disabling colorization? i sometimes run my tests inside an emacs compilation buffer and i'd rather not have ansi colors there... thanks! |
@jaor It's probably a simple PR, but you might look at this https://github.com/greglook/puget, too. |
On Wed, Jun 07 2017, Kendall Buchanan wrote:
@jaor It's probably a simple PR, but you might look at this
https://github.com/greglook/puget, too.
thanks kendall. i looked around, but since it's spyscope whose calling
puget under the rug, i didn't see an easy way of telling `#spy/p` to
pass printer configuration params in its calls to puget. i guess i can
set somewhere in my `~.lein/profiles.clj` a binding for
`puget.printer/*options*`, but i was wondering whether there was
something quick on spyscope's side.
|
I think that setting the binding is your best bet. I was going to suggest adding a binding to spyscope, but since puget already has that, you should be set! |
On Wed, Jun 07 2017, David Greenberg wrote:
I think that setting the binding is your best bet. I was going to
suggest adding a binding to spyscope, but since puget already has
that, you should be set!
i still think a spyscope-specific setting would be a good idea, and
would also protect your users from surprises the day you decide to
switch from puget to something else (if that day ever arrives; but then
a switch has already happened, and it has surprised me for one).
fwiw, imho, etc.
thanks!
|
Any interest in incorporating puget for colorization, either as the out-of-the-box or optional behavior? I'd be happy to submit a pull request.
If not, any suggestions on how to make them work together?
The text was updated successfully, but these errors were encountered: