Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#spy/d stopped working in 1.9? #26

Open
mattiasw2 opened this issue Feb 10, 2017 · 20 comments
Open

#spy/d stopped working in 1.9? #26

mattiasw2 opened this issue Feb 10, 2017 · 20 comments

Comments

@mattiasw2
Copy link

mattiasw2 commented Feb 10, 2017

 (take 20 (repeat #spy/d (+ 1 2 3)))

gives

     ClassCastException java.io.StringWriter cannot be cast to clojure.lang.Associative  clojure.lang.RT.assoc (RT.java:807)

in clojure 1.9 with spyscope 1.6

@saulshanabrook
Copy link

Maybe this was fixed in #23? If so, could you do a release with this change in it?

@schmee
Copy link
Contributor

schmee commented Mar 5, 2017

@saulshanabrook I don't think that's the same issue. 1.5 doesn't even load in Clojure 1.9 due to the new spec-ed core macros, but 1.6 works and is already on Clojars. That said, I just ran into this as well.

@mattiasw2
Copy link
Author

Are you saying that 1.6 works with clojure 1.9? For me, only #spy/p works. For #spy/t and #spy/d, I get the ClassCastException.

So, I am waiting for a 1.7. (I really wished I know a simple way to make lein use the latest spycore from github.)

@schmee
Copy link
Contributor

schmee commented Mar 5, 2017

I'm saying that before 1.6, Spyscope didn't even load in Clojure 1.9. If I understand thing correctly, this issue (about #spy/d not working) is not solved by #23, and the bug is is still present in master.

@schmee
Copy link
Contributor

schmee commented Aug 7, 2017

This has been fixed by #25. The new version is not up on Clojars however, so to make it work, clone this repo and run lein install on the master branch and update your code to use [spyscope "0.1.7-SNAPSHOT"].

@seancorfield
Copy link

Someone just asked about spyscope in #clojure on the Clojurians Slack. The README still shows 0.1.5 as the current version(!) and they're on Clojure 1.9 so they didn't know about 0.1.6 including the fix for the bad ns forms.

Since there's a blocking bug in 0.1.6 with a fix already in master, it would be nice if @dgrnbrg could cut a 0.1.7 release with that fix and update the README to show that as the latest version.

@waffletower
Copy link
Contributor

I would just make a pull request for the readme. Since Clojure 1.9 now has an RC1 build, we might be able to persuade @dgrnbrg to push a jar to clojars.

@expez
Copy link

expez commented Jan 16, 2018

Clojure 1.9 is out now. Would be lovely to get a new jar.

@waffletower
Copy link
Contributor

Maybe he could be convinced to release 1.7 after approving the clojurescript PR.

@emil0r
Copy link

emil0r commented Sep 20, 2018

Any news on this? Bit annoying to have a SNAPSHOT locally installed. Love the library, but please release a new version to Clojars!

@randomizedthinking
Copy link

Any update on the fix for Clojure 1.9, or maybe even Clojure 1.10?

@dgrnbrg
Copy link
Owner

dgrnbrg commented Dec 23, 2018 via email

@randomizedthinking
Copy link

I am a Clojure new comer. Yet, if someone would like to help me out, I'd like to take the role to manage the new releases.

@expez
Copy link

expez commented Dec 28, 2018

@slipset Is this something clj-commons might be interested in adopting? That way @randomizedthinking has someone to help him with maintainership logistics?

Does that sound interesting to you too, @dgrnbrg?

You can read more about clj-commons here but in short it's an org set up to let finished / unmaintained projects sunset gracefully.

@buzzdan
Copy link

buzzdan commented Mar 3, 2019

Any updates on this issue?

@mk12
Copy link

mk12 commented Aug 2, 2019

Looks like someone else has published 0.1.7 on clojars. I'm using that for now -- #spy/d seems to be working on Clojure 1.10.

@rbeesley
Copy link

rbeesley commented Jan 29, 2021

Looks like someone else has published 0.1.7 on clojars. I'm using that for now -- #spy/d seems to be working on Clojure 1.10.

On Clojure 1.8.0 -> 1.10.2, I can't get this version to load. Not sure what's going on. I tried to add the dependencies in project.clj based on the documentation for the 1.6 version with changes to match the 1.7 version referenced here:

:dependencies [[spieden/spyscope "0.1.7"]]
:injections [(require 'spyscope.core)]

However I get this error when starting my REPL:

user.core=> (require 'spyscope.core)
Syntax error (IllegalArgumentException) compiling deftype* at (clojure\core\rrb_vector\rrbt.clj:282:1).
Must hint overloaded method: toArray

This seems to be coming from when I require the namespace because it won't happen immediately until I use or require spyscope.core.

Edit: Looks like it might be because I have Java 15.0.1 running.

Edit 2: Seemed to resolve things using the :managed-dependency suggestion from issue #32 (comment), and the above 0.1.7 version of this library.

Edit 3: For completeness, if anyone else hits this, I used the following in my project.clj:

:profiles {:skyscope {:dependencies [[spieden/spyscope "0.1.7"]]
                      ;; Force Spyscope to use a newer version of rrb-vector that is compatible with Java 11
                      :managed-dependencies [[org.clojure/core.rrb-vector "0.1.2"]]
                      :injections [(require 'spyscope.core)]}

This was working with Clojure 1.10.2 on AdoptOpenJDK (build 15.0.1+9).

@waffletower
Copy link
Contributor

waffletower commented Jan 30, 2021 via email

@slipset
Copy link

slipset commented Jan 30, 2021

I've released clj-commons/spyscope here https://clojars.org/clj-commons/spyscope
Updated all libs to most recent.

@rbeesley
Copy link

rbeesley commented Feb 9, 2021

@slipset, seems to be working with the clj-commons release with no additional dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests