-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#spy/d stopped working in 1.9? #26
Comments
Maybe this was fixed in #23? If so, could you do a release with this change in it? |
@saulshanabrook I don't think that's the same issue. 1.5 doesn't even load in Clojure 1.9 due to the new spec-ed core macros, but 1.6 works and is already on Clojars. That said, I just ran into this as well. |
Are you saying that 1.6 works with clojure 1.9? For me, only #spy/p works. For #spy/t and #spy/d, I get the ClassCastException. So, I am waiting for a 1.7. (I really wished I know a simple way to make lein use the latest spycore from github.) |
I'm saying that before 1.6, Spyscope didn't even load in Clojure 1.9. If I understand thing correctly, this issue (about |
This has been fixed by #25. The new version is not up on Clojars however, so to make it work, clone this repo and run |
Someone just asked about spyscope in #clojure on the Clojurians Slack. The README still shows 0.1.5 as the current version(!) and they're on Clojure 1.9 so they didn't know about 0.1.6 including the fix for the bad Since there's a blocking bug in 0.1.6 with a fix already in master, it would be nice if @dgrnbrg could cut a 0.1.7 release with that fix and update the README to show that as the latest version. |
I would just make a pull request for the readme. Since Clojure 1.9 now has an RC1 build, we might be able to persuade @dgrnbrg to push a jar to clojars. |
Clojure 1.9 is out now. Would be lovely to get a new jar. |
Maybe he could be convinced to release 1.7 after approving the clojurescript PR. |
Any news on this? Bit annoying to have a SNAPSHOT locally installed. Love the library, but please release a new version to Clojars! |
Any update on the fix for Clojure 1.9, or maybe even Clojure 1.10? |
I’d be happy to add another contributor to manage new releases!
…On Sat, Dec 22, 2018 at 7:39 PM randomizedthinking ***@***.***> wrote:
Any update on the fix for Clojure 1.9, or maybe even Clojure 1.10?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAlwC_KiDz36UDLljnvME3sBBHvsgCWiks5u7tDagaJpZM4L9V8w>
.
|
I am a Clojure new comer. Yet, if someone would like to help me out, I'd like to take the role to manage the new releases. |
@slipset Is this something clj-commons might be interested in adopting? That way @randomizedthinking has someone to help him with maintainership logistics? Does that sound interesting to you too, @dgrnbrg? You can read more about clj-commons here but in short it's an org set up to let finished / unmaintained projects sunset gracefully. |
Any updates on this issue? |
Looks like someone else has published 0.1.7 on clojars. I'm using that for now -- |
On Clojure 1.8.0 -> 1.10.2, I can't get this version to load. Not sure what's going on. I tried to add the dependencies in
However I get this error when starting my REPL:
This seems to be coming from when I require the namespace because it won't happen immediately until I Edit: Looks like it might be because I have Java 15.0.1 running. Edit 2: Seemed to resolve things using the Edit 3: For completeness, if anyone else hits this, I used the following in my
This was working with Clojure 1.10.2 on AdoptOpenJDK (build 15.0.1+9). |
I believe updating the fipp dependency repairs this.
I have a fork of 0.1.7 here:
https://github.com/waffletower/spyscope
…On Thu, Jan 28, 2021 at 7:00 PM Ryan Beesley ***@***.***> wrote:
Looks like someone else has published 0.1.7 on clojars
<https://clojars.org/spieden/spyscope>. I'm using that for now -- #spy/d
seems to be working on Clojure 1.10.
On Clojure 1.8.0 -> 1.10.2, I can't get *this* version to load. Not sure
what's going on. I tried to add the dependencies in project.cli based on
the documentation for the 1.6 version with changes to match the 1.7 version
referenced here:
:dependencies [[spieden/spyscope "0.1.7"]]
:injections [(require 'spyscope.core)]
However I get this error when starting my REPL:
user.core=> (require 'spyscope.core)
Syntax error (IllegalArgumentException) compiling deftype* at (clojure\core\rrb_vector\rrbt.clj:282:1).
Must hint overloaded method: toArray
This seems to be coming from when I require the namespace because it won't
happen immediately until I use or require spyscope.core.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBXMT4CAA63HDGSRM23NDLS4IQDTANCNFSM4C7VL4YA>
.
|
I've released clj-commons/spyscope here https://clojars.org/clj-commons/spyscope |
@slipset, seems to be working with the clj-commons release with no additional dependencies. |
gives
in clojure 1.9 with spyscope 1.6
The text was updated successfully, but these errors were encountered: