Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EO principle violation in Inbox.java #50

Open
fanifieiev opened this issue Jan 23, 2020 · 1 comment
Open

EO principle violation in Inbox.java #50

fanifieiev opened this issue Jan 23, 2020 · 1 comment

Comments

@fanifieiev
Copy link

fanifieiev commented Jan 23, 2020

I think there is a EO principle violation in Inbox.java.
The only method's name is read which returns sth, but according to Yehor's EO principles, it should be a noun not a verb.

What about below?
Iterable<Msg> messages(Query query) throws EmailException;

@dgroup
Copy link
Owner

dgroup commented Jun 13, 2020

Hi @fanifieiev,
I like this idea, the messages is a better name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants