Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible with performance regression in 1.36.0 release #2105

Closed
ggilmore opened this issue Nov 30, 2020 · 2 comments · Fixed by #2112
Closed

possible with performance regression in 1.36.0 release #2105

ggilmore opened this issue Nov 30, 2020 · 2 comments · Fixed by #2112

Comments

@ggilmore
Copy link

ggilmore commented Nov 30, 2020 •
edited
Loading

Related #1960

When I run dhall against a file with a lot of chained with statements, dhall 1.36.0 seems to choke while dhall 1.35.0 executes the file quickly.

I've created a reproduction repository here: https://github.com/ggilmore/dhall-performance-regression-example-with

Run dhall 1.35.0 with dhall --file=src/fast-1.35.0/fast.dhall - see that the command executes quickly

Run dhall 1.36.0 with dhall --file=src/slow-1.36.0/slow.dhall - see that the command never terminates
@Gabriella439
Copy link
Collaborator

Yeah, I'm pretty sure I know what went wrong here. The regression is likely due to #2055 and I believe I can fix it by using an optimization similar to the one we used back when with was syntactic sugar.

Gabriella439 added a commit that referenced this issue Dec 8, 2020
@Gabriella439
Fix performance regression for with expressions
fa60d59 
Fixes: #2105
@Gabriella439 Gabriella439 mentioned this issue Dec 8, 2020
Merged
@Gabriella439
Copy link
Collaborator

Fix is up here: #2112

@mergify mergify bot closed this as completed in #2112 Dec 10, 2020
mergify bot pushed a commit that referenced this issue Dec 10, 2020
@Gabriella439
Fix performance regression for with expressions (#2112)
9fd070f 
Fixes: #2105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix performance regression for with expressions dhall-lang/dhall-haskell
2 participants
@Gabriella439 @ggilmore