Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix TestDNS_ServiceLookup_ARecordLimits so that it only creates test agents the minimal amount of time into release/1.19.x #193

Open
4 tasks
dhiaayachi opened this issue Sep 25, 2024 · 0 comments

Comments

@dhiaayachi
Copy link
Owner

Backport

This PR is auto-generated from hashicorp#21608 to be assessed for backporting due to the inclusion of the label backport/1.19.

The below text is copied from the body of the original PR.


Description

TestDNS_ServiceLookup_ARecordLimits is one of our longest running tests.

It's average runtime in CI over the last 3 months is 1min 45 secs.

Locally on a mac M1, it performs in 1 min 11 seconds:
Screenshot 2024-08-15 at 7 04 21 AM

The reason why is that for every test case it spawns a new TestAgent. This is 112 test agents getting spawned, taking up ports, file descriptors, etc.

Re-arranging this test so that test agents are only created when the agent config changes, reduces it to 7 Test Agents getting created. (There was also a category of tests that could be removed as duplicates that removed 28 of the test agent).

This is the test results locally now that finish in 10 secs:
Screenshot 2024-08-15 at 9 20 19 AM

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant