Fix day-of reporting

[mikeputnam]

You may want to look at what I've done here on the Android client in order to handle they way upstream bumps their recycling date.

https://github.com/mikeputnam/isitrecyclingweek/blob/master/mobile/src/main/java/theputnams/net/isitrecyclingweek/GarbageAndOrRecycleActivity.java#L236-L251

The API simply passes along the data from upstream, and upstream toggles the new recycling date at 12am on the recycling day. This means the actual day of recycling misreports as the next recycle date.

[chrisjaure]

Thanks, I'll take a look. For clarification, how does this issue manifest itself in the UI?

[mikeputnam]

The Android client UI revolves around the question "Is it recycling week?" implicitly measured from the current date/time. This web client explicitly displays whatever the next pickup day is and tells the user if it is recycling or not.

In the Android case, when a user checks the morning of the pickup, the API has already bumped forward to the next pickup date. So the central question (and implict assumption of current date/time) becomes wrong.

Maybe in the case of your web client, the explicit pickup date makes this issue void. Not sure.