Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On/off not showing ios16 #28

Open
Stianker1 opened this issue Sep 27, 2022 · 3 comments
Open

On/off not showing ios16 #28

Stianker1 opened this issue Sep 27, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Stianker1
Copy link

Hello,
I know that you are not frequently updating this plugin because you are now over on home assistant, but could you maybe see why the on/off scroll is not showing any letters?

068755ED-7F3A-40ED-BE32-064F7C17D575

@Stianker1 Stianker1 added the bug Something isn't working label Sep 27, 2022
@dhutchison
Copy link
Owner

I'm going to over the next few days do some dependency updates and see how it works after that. Not entirely sure how that could be caused by a plugin but we'll see if I can replicate it.

@dhutchison
Copy link
Owner

I feel I should add a bit of an update here. I've been busy, this isn't something I use directly etc etc.

However, tried looking at this a bit & getting weird issues with the unit tests (particularly around headers in axios/mocks). Not something I expected to break at all tbh. I'll poke about it a bit more this week but if anyone knows what might have changed in axios recently please let me know!

@dhutchison
Copy link
Owner

Ok ended up rolling axios back to a 0.x release & the tests are back to passing. It looks like there is some incompatibilities between the mocking library and axios v1 that have not been fixed yet.

Back to the original issue (since I just compared an iOS 15 & 16 device) - if it is the blue button you are talking about then it looks like that doesn't show any text if there are only two options (in our case heat/off). That doesn't seem to be a change. Is that what you were meaning?

If you want to hide the button entirely and only use the temperature settings you can add to the config "includeOffOption": false,.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants