From fae41c3d1c92a3db378cd5ab342ea772479e2062 Mon Sep 17 00:00:00 2001 From: meek Date: Mon, 23 Oct 2023 13:44:18 +0200 Subject: [PATCH] SingleLayerTeams with no target squad fix --- microfreshener/core/analyser/sniffer.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/microfreshener/core/analyser/sniffer.py b/microfreshener/core/analyser/sniffer.py index c084901..c834963 100644 --- a/microfreshener/core/analyser/sniffer.py +++ b/microfreshener/core/analyser/sniffer.py @@ -111,8 +111,9 @@ def snif(self, group: Team)->SingleLayerTeamsSmell: target_node = relationship.target source_squad = self.micro_model.squad_of(source_node) target_squad = self.micro_model.squad_of(target_node) - if (isinstance(source_node, Service) and isinstance(target_node, Datastore) - and source_squad != target_squad): + if (target_squad is None or + (isinstance(source_node, Service) and isinstance(target_node, Datastore) + and source_squad != target_squad)): smell.addLinkCause(relationship) return smell