From 1883cbb0c237995ff8507f5ba92963b400f7841f Mon Sep 17 00:00:00 2001 From: Michele Agostini Date: Tue, 30 Apr 2024 16:46:11 +0200 Subject: [PATCH 1/2] SLT definition update Single-Layer Teams smell aligned to latest updated definition --- .../refactoring/refactorings/refactoring-factory.service.ts | 2 +- client/src/app/refactoring/smells/single-layer-teams.ts | 3 ++- client/src/app/refactoring/smells/smell-factory.service.ts | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/client/src/app/refactoring/refactorings/refactoring-factory.service.ts b/client/src/app/refactoring/refactorings/refactoring-factory.service.ts index 7818375b..7cc82491 100644 --- a/client/src/app/refactoring/refactorings/refactoring-factory.service.ts +++ b/client/src/app/refactoring/refactorings/refactoring-factory.service.ts @@ -169,7 +169,7 @@ export class RefactoringFactoryService { switch(refactoringName) { case REFACTORING_LIBRARY_NAMES.SPLIT_TEAMS_BY_MICROSERVICE: - return new SplitTeamsByMicroserviceRefactoring(this.gs.graph, smell); + break;//return new SplitTeamsByMicroserviceRefactoring(this.gs.graph, smell); case REFACTORING_LIBRARY_NAMES.SPLIT_TEAMS_BY_COUPLING: return new SplitTeamsByCouplingRefactoring(this.gs.graph, smell); diff --git a/client/src/app/refactoring/smells/single-layer-teams.ts b/client/src/app/refactoring/smells/single-layer-teams.ts index 9f7ff671..fbd1ca79 100644 --- a/client/src/app/refactoring/smells/single-layer-teams.ts +++ b/client/src/app/refactoring/smells/single-layer-teams.ts @@ -13,6 +13,7 @@ export class SingleLayerTeamsSmellObject extends GroupSmell { getDescription(): string { let services = new Set(); this.getLinkBasedCauses().forEach(link => { services.add(link.getSourceElement()); console.debug(`${( link.getSourceElement()).getName()} added`) }); - return `Data related to ${Array.from(services).map((service) => service.getName()).join(", ")} is being managed by other teams.\n`; + return super.getGroup()?.getName() + " may be designed basing on technology layers."; + //return `Data related to ${Array.from(services).map((service) => service.getName()).join(", ")} is being managed by other teams.\n`; } } \ No newline at end of file diff --git a/client/src/app/refactoring/smells/smell-factory.service.ts b/client/src/app/refactoring/smells/smell-factory.service.ts index 77d94468..8bbb05f6 100644 --- a/client/src/app/refactoring/smells/smell-factory.service.ts +++ b/client/src/app/refactoring/smells/smell-factory.service.ts @@ -127,7 +127,7 @@ export class SmellFactoryService { let refactoringName = refactoringJson['name']; console.debug("Analysing refactoring", refactoringName); let refactoring: GroupRefactoring = this.refactoring.getRefactoring(refactoringName, smell); - smell.addRefactoring(refactoring); + if(refactoring) smell.addRefactoring(refactoring); }); smell.addRefactoring(this.refactoring.getIgnoreRefactoring(group, smell)); From 26e99293f3e8605619b4686f05404f0b06244285 Mon Sep 17 00:00:00 2001 From: Michele Agostini Date: Tue, 7 May 2024 12:39:31 +0200 Subject: [PATCH 2/2] Dependency update to microfreshener-core 1.5.0 to support organizational smells - Dependency update to microfreshener-core 1.5.0 supporting organizational smells - Dependencies to remote git or local core distributions are left commented for further development purposes --- server/requirements.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/requirements.txt b/server/requirements.txt index 1a69a09b..8f356524 100644 --- a/server/requirements.txt +++ b/server/requirements.txt @@ -15,9 +15,9 @@ idna==2.8 itypes==1.1.0 Jinja2==2.10.1 MarkupSafe==1.1.1 -microfreshener-core==1.4.0 -#microfreshener-core @ git+https://github.com/di-unipi-socc/microFreshener-core.git@master -#../../microFreshener-core +microfreshener-core==1.5.0 +#../../microFreshener-core # Dev only +#microfreshener-core @ git+https://github.com/di-unipi-socc/microFreshener-core.git@master # Dev only nested-lookup==0.2.19 openapi-codec==1.3.2 pbr==5.4.2