Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History audio replay does not respect start and end timecodes #2

Open
KvaGram opened this issue Jul 10, 2022 · 1 comment
Open

History audio replay does not respect start and end timecodes #2

KvaGram opened this issue Jul 10, 2022 · 1 comment

Comments

@KvaGram
Copy link
Contributor

KvaGram commented Jul 10, 2022

The problem

Describe the bug
When opening the history panel while running a dialog, and pressing the play button, the while audiofile is played.

To Reproduce
Steps to reproduce the behavior:

  1. Enable history and audio for text events
  2. play a timeline featuring voiced lines with timecodes not starting at 0 secunds.
  3. press history button
  4. press the play button on a line filling the step 2 criteria.
  5. observe the whole audiofile being played instead of the one desired line

Expected behavior
Only the part of the audio defined in the audio-region should be played.

System (please complete the following information):

  • OS: Linux Mint 20
  • Godot Version: 3.4.4
  • Dialogic Version: 1.4.3 (dev)

Solutions

Workaround

None found.

Possible fixes

Implement the audio region feature in history.

@zaknafean zaknafean changed the title History audio replay does not respect start and end timecodes 1.4.x - History audio replay does not respect start and end timecodes Jul 12, 2022
@Jowan-Spooner
Copy link
Collaborator

Duplicate of dialogic-godot/dialogic#765 gonna keep this one as it is more detailed.

@coppolaemilio coppolaemilio changed the title 1.4.x - History audio replay does not respect start and end timecodes History audio replay does not respect start and end timecodes Jul 24, 2022
@Jowan-Spooner Jowan-Spooner transferred this issue from dialogic-godot/dialogic Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants