You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On upgrading the mirror example to 1.5.0 I noticed everything got very dark.
Setting renderer=colorManagement: false got us back to the original display.
However, ideally mirrors should work with colorManagement enabled, especially as this is the default from 1.5.0.
I have created a test page with a mirror, and colorManagement enabled. With 1.4.2 the reflections are noticeably darker, but not too bad. WIth 1.5.0, they are much darker still. Back in 1.2.0 the reflections weren't darkened at all.
Some pics (all with color management enabled):
1.5.0
1.4.2
1.3.0 (looks the same as 1.4.2 to me)
1.2.0
The text was updated successfully, but these errors were encountered:
With that change, reflections with 1.5.0 and color management enabled do seem a little less dark.
But more significantly there's a massive perf degradation - the mirror example was running at < 3fps on the latest code, vs. about 15fps with the previous code.
The 'color' attribute had been intended to color the back side of the mirror, so some work needed to color the back correctly without affecting performance of the mirror front.
A-Frame 1.5.0 has enabled color management by default
See: aframevr/aframe#5383 and aframevr/aframe#5210
On upgrading the mirror example to 1.5.0 I noticed everything got very dark.
Setting
renderer=colorManagement: false
got us back to the original display.However, ideally mirrors should work with colorManagement enabled, especially as this is the default from 1.5.0.
I have created a test page with a mirror, and colorManagement enabled. With 1.4.2 the reflections are noticeably darker, but not too bad. WIth 1.5.0, they are much darker still. Back in 1.2.0 the reflections weren't darkened at all.
Some pics (all with color management enabled):
1.5.0
1.4.2
1.3.0 (looks the same as 1.4.2 to me)
1.2.0
The text was updated successfully, but these errors were encountered: