Update icon and use <draft> and <untitled> as our placeholders.

Author: nedtwigg

src/lib/enhancers/github/GitHubIssueAppendEnhancer.tsx

@@ -91,7 +91,7 @@ export class GitHubIssueAppendEnhancer
           <IssueOpenedIcon size={16} />
         </span>
         <span>
-          #{spot.number} |{" "}
+          #{spot.number}{" "}
           <a
             href={`https://${spot.domain}/${spot.slug}`}
             className="truncate hover:underline"

src/lib/enhancers/github/GitHubIssueCreateEnhancer.tsx

@@ -11,16 +11,15 @@ import { commonGitHubOptions, prepareGitHubHighlighter } from "./github-common"
 
 const GH_ISSUE_CREATE = "GH_ISSUE_CREATE" as const
 
-interface GitHubIssueCreateSpot extends CommentSpot {
+export interface GitHubIssueCreateSpot extends CommentSpot {
   type: typeof GH_ISSUE_CREATE
   domain: string
   slug: string // owner/repo
   title: string
 }
 
 export class GitHubIssueCreateEnhancer
-  implements CommentEnhancer<GitHubIssueCreateSpot>
-{
+  implements CommentEnhancer<GitHubIssueCreateSpot> {
   forSpotTypes(): string[] {
     return [GH_ISSUE_CREATE]
   }
@@ -81,7 +80,7 @@ export class GitHubIssueCreateEnhancer
           <IssueOpenedIcon size={16} />
         </span>
         <span>
-          New |{" "}
+          &lt;draft&gt;{" "}
           <a
             href={`https://${spot.domain}/${spot.slug}`}
             className="truncate hover:underline"
@@ -94,7 +93,7 @@ export class GitHubIssueCreateEnhancer
   }
 
   tableTitle(spot: GitHubIssueCreateSpot): string {
-    return spot.title || "New Issue"
+    return spot.title || "<untitled issue>"
   }
 
   buildUrl(spot: GitHubIssueCreateSpot): string {

src/lib/enhancers/github/GitHubPrAppendEnhancer.tsx

@@ -1,4 +1,4 @@
-import { FeedPullRequestOpenIcon } from "@primer/octicons-react"
+import { GitPullRequestIcon } from "@primer/octicons-react"
 import OverType, { type OverTypeInstance } from "overtype"
 import type React from "react"
 import type {
@@ -87,10 +87,10 @@ export class GitHubPrAppendEnhancer
     return (
       <>
         <span className="flex h-4 w-4 flex-shrink-0 items-center justify-center">
-          <FeedPullRequestOpenIcon size={16} />
+          <GitPullRequestIcon size={16} />
         </span>
         <span>
-          #{spot.number} |{" "}
+          #{spot.number}{" "}
           <a
             href={`https://${spot.domain}/${spot.slug}`}
             className="truncate hover:underline"

src/lib/enhancers/github/GitHubPrCreateEnhancer.tsx

@@ -1,4 +1,4 @@
-import { FeedPullRequestOpenIcon } from "@primer/octicons-react"
+import { GitPullRequestIcon } from "@primer/octicons-react"
 import OverType, { type OverTypeInstance } from "overtype"
 import type {
   CommentEnhancer,
@@ -11,18 +11,17 @@ import { commonGitHubOptions, prepareGitHubHighlighter } from "./github-common"
 
 const GH_PR_CREATE = "GH_PR_CREATE" as const
 
-interface GitHubPrCreateSpot extends CommentSpot {
+export interface GitHubPrCreateSpot extends CommentSpot {
   type: typeof GH_PR_CREATE
   domain: string
   slug: string // owner/repo
   title: string
-  head: string // `user:repo:branch` where changes are implemented
+  head: string // `user:repo:branch ` where changes are implemented
   base: string // branch you want changes pulled into
 }
 
 export class GitHubPrCreateEnhancer
-  implements CommentEnhancer<GitHubPrCreateSpot>
-{
+  implements CommentEnhancer<GitHubPrCreateSpot> {
   forSpotTypes(): string[] {
     return [GH_PR_CREATE]
   }
@@ -93,10 +92,10 @@ export class GitHubPrCreateEnhancer
     return (
       <>
         <span className="flex h-4 w-4 flex-shrink-0 items-center justify-center">
-          <FeedPullRequestOpenIcon size={16} />
+          <GitPullRequestIcon size={16} />
         </span>
         <span>
-          New |{" "}
+          &lt;draft&gt;{" "}
           <a
             href={`https://${spot.domain}/${spot.slug}`}
             className="truncate hover:underline"
@@ -109,7 +108,7 @@ export class GitHubPrCreateEnhancer
   }
 
   tableTitle(spot: GitHubPrCreateSpot): string {
-    return spot.title || "New Pull Request"
+    return spot.title || "<untitled pull request>"
   }
 
   buildUrl(spot: GitHubPrCreateSpot): string {

tests/lib/enhancers/__snapshots__/gh-ui.test.ts.snap

@@ -16,7 +16,6 @@ exports[`github ui > gh_issue:should render correct UI elements 1`] = `
       <span>
         #
         523
-         |
          
         <a
           className="truncate hover:underline"
@@ -53,7 +52,6 @@ exports[`github ui > gh_issue_edit:should render correct UI elements 1`] = `
       <span>
         #
         56
-         |
          
         <a
           className="truncate hover:underline"
@@ -97,7 +95,6 @@ exports[`github ui > gh_issue_edit_multiple:should render correct UI elements 1`
       <span>
         #
         3
-         |
          
         <a
           className="truncate hover:underline"
@@ -125,7 +122,7 @@ exports[`github ui > gh_issue_new:should render correct UI elements 1`] = `
         />
       </span>
       <span>
-        New |
+        &lt;draft&gt;
          
         <a
           className="truncate hover:underline"
@@ -149,14 +146,13 @@ exports[`github ui > gh_pr:should render correct UI elements 1`] = `
       <span
         className="flex h-4 w-4 flex-shrink-0 items-center justify-center"
       >
-        <FeedPullRequestOpenIcon
+        <GitPullRequestIcon
           size={16}
         />
       </span>
       <span>
         #
         517
-         |
          
         <a
           className="truncate hover:underline"
@@ -188,14 +184,13 @@ exports[`github ui > gh_pr_edit:should render correct UI elements 1`] = `
       <span
         className="flex h-4 w-4 flex-shrink-0 items-center justify-center"
       >
-        <FeedPullRequestOpenIcon
+        <GitPullRequestIcon
           size={16}
         />
       </span>
       <span>
         #
         58
-         |
          
         <a
           className="truncate hover:underline"
@@ -233,14 +228,13 @@ exports[`github ui > gh_pr_edit_multiple:should render correct UI elements 1`] =
       <span
         className="flex h-4 w-4 flex-shrink-0 items-center justify-center"
       >
-        <FeedPullRequestOpenIcon
+        <GitPullRequestIcon
           size={16}
         />
       </span>
       <span>
         #
         5
-         |
          
         <a
           className="truncate hover:underline"
@@ -263,12 +257,12 @@ exports[`github ui > gh_pr_new:should render correct UI elements 1`] = `
       <span
         className="flex h-4 w-4 flex-shrink-0 items-center justify-center"
       >
-        <FeedPullRequestOpenIcon
+        <GitPullRequestIcon
           size={16}
         />
       </span>
       <span>
-        New |
+        &lt;draft&gt;
          
         <a
           className="truncate hover:underline"