Can be replaced with String.repeat()

Author: Vincent Potucek

lib/src/main/java/com/diffplug/spotless/generic/EndWithNewlineStep.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016 DiffPlug
+ * Copyright 2016-2025 DiffPlug
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -52,10 +52,7 @@ private static String format(String rawUnix) {
 		} else if (lastContentCharacter == rawUnix.length() - 2 && rawUnix.charAt(rawUnix.length() - 1) == '\n') {
 			return rawUnix;
 		} else {
-			StringBuilder builder = new StringBuilder(lastContentCharacter + 2);
-			builder.append(rawUnix, 0, lastContentCharacter + 1);
-			builder.append('\n');
-			return builder.toString();
+			return rawUnix.substring(0, lastContentCharacter + 1) + '\n';
 		}
 	}
 }

lib/src/main/java/com/diffplug/spotless/generic/IndentStep.java

@@ -104,14 +104,10 @@ String format(String raw) {
 				if (numSpaces > 0) {
 					switch (state.type) {
 					case SPACE:
-						for (int i = 0; i < numSpaces; i++) {
-							builder.append(' ');
-						}
+						builder.append(" ".repeat(numSpaces));
 						break;
 					case TAB:
-						for (int i = 0; i < numSpaces / state.numSpacesPerTab; i++) {
-							builder.append('\t');
-						}
+						builder.append("\t".repeat(numSpaces / state.numSpacesPerTab));
 						if (mightBeMultiLineComment && (numSpaces % state.numSpacesPerTab == 1)) {
 							builder.append(' ');
 						}

lib/src/main/java/com/diffplug/spotless/sql/dbeaver/DBeaverSQLFormatterConfiguration.java

@@ -15,6 +15,8 @@
  */
 package com.diffplug.spotless.sql.dbeaver;
 
+import static java.lang.Integer.parseInt;
+
 import java.util.Properties;
 
 import com.diffplug.spotless.annotations.Internal;
@@ -59,18 +61,13 @@ public DBeaverSQLFormatterConfiguration(Properties properties) {
 		this.keywordCase = KeywordCase.valueOf(properties.getProperty(SQL_FORMATTER_KEYWORD_CASE, "UPPER"));
 		this.statementDelimiters = properties.getProperty(SQL_FORMATTER_STATEMENT_DELIMITER, SQLDialect.INSTANCE
 				.getScriptDelimiter());
-		String indentType = properties.getProperty(SQL_FORMATTER_INDENT_TYPE, "space");
-		int indentSize = Integer.parseInt(properties.getProperty(SQL_FORMATTER_INDENT_SIZE, "4"));
-		indentString = getIndentString(indentType, indentSize);
+		indentString = getIndentString(
+				properties.getProperty(SQL_FORMATTER_INDENT_TYPE, "space"),
+				parseInt(properties.getProperty(SQL_FORMATTER_INDENT_SIZE, "4")));
 	}
 
 	private String getIndentString(String indentType, int indentSize) {
-		char indentChar = "space".equals(indentType) ? ' ' : '\t';
-		StringBuilder stringBuilder = new StringBuilder();
-		for (int i = 0; i < indentSize; i++) {
-			stringBuilder.append(indentChar);
-		}
-		return stringBuilder.toString();
+		return String.valueOf("space".equals(indentType) ? ' ' : '\t').repeat(indentSize);
 	}
 
 	String getStatementDelimiter() {

lib/src/main/java/com/diffplug/spotless/sql/dbeaver/FormatterToken.java

@@ -65,12 +65,10 @@ public int getPos() {
 
 	@Override
 	public String toString() {
-		final StringBuilder buf = new StringBuilder();
-		buf.append(getClass().getName());
-		buf.append("type=").append(fType);
-		buf.append(",string=").append(fString);
-		buf.append(",pos=").append(fPos);
-		buf.append("]");
-		return buf.toString();
+		return getClass().getName() +
+				"type=" + fType +
+				",string=" + fString +
+				",pos=" + fPos +
+				"]";
 	}
 }

lib/src/main/java/com/diffplug/spotless/sql/dbeaver/SQLTokenizedFormatter.java

@@ -399,9 +399,7 @@ private int insertReturnAndIndent(final List<FormatterToken> argList, final int
 		try {
 			final String defaultLineSeparator = getDefaultLineSeparator();
 			StringBuilder s = new StringBuilder(defaultLineSeparator);
-			for (int index = 0; index < argIndent; index++) {
-				s.append(formatterCfg.getIndentString());
-			}
+			s.append(formatterCfg.getIndentString().repeat(argIndent));
 			if (argIndex > 0) {
 				final FormatterToken token = argList.get(argIndex);
 				final FormatterToken prevToken = argList.get(argIndex - 1);