Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust blob store download to selectively download only photo previews and thumbnails based on device setting #681

Closed
EvanHahn opened this issue May 27, 2024 · 1 comment · Fixed by #940
Closed

Adjust blob store download to selectively download only photo previews and thumbnails based on device setting #681

EvanHahn opened this issue May 27, 2024 · 1 comment · Fixed by #940
Assignees
@EvanHahn
Labels
Project: Disk Space Management v1

Comments

@EvanHahn
Copy link
Contributor

No description provided.

@EvanHahn EvanHahn self-assigned this Aug 26, 2024
@EvanHahn EvanHahn removed their assignment Oct 10, 2024
@gmaclennan gmaclennan self-assigned this Oct 24, 2024
@gmaclennan gmaclennan mentioned this issue Oct 29, 2024
Merged
1 task
@EvanHahn EvanHahn assigned EvanHahn and unassigned gmaclennan Oct 30, 2024
EvanHahn added a commit that referenced this issue Nov 5, 2024
@gmaclennan @EvanHahn
feat: blobStore.setDownloadFilter() & `createEntriesReadableStream(…
0a2db23 
…)` (#940)

- Removes `blobStore.download()` and the `LiveDownload` class.
- Adds `blobStore.createEntriesReadableStream()` which is a stream of
  all entries in the blob store, filtered by blob type and variant(s).
- Changes behaviour of `BlobStore` to auto-download blobs according to a
  `downloadFilter`.
- Changes the `BlobStore` filter according to `isArchiveDevice` setting.
- Changes the behaviour of `CoreManager` to not auto-download blob cores
  (this responsibility is now with `BlobStore`).

Closes [#681].

[#681]: #681

Co-authored-by: Evan Hahn <[email protected]>
@EvanHahn
Copy link
Contributor Author

EvanHahn commented Nov 5, 2024

Done in 0a2db23.

@EvanHahn EvanHahn closed this as completed Nov 5, 2024
EvanHahn added a commit that referenced this issue Nov 7, 2024
@gmaclennan @EvanHahn
feat: blobStore.setDownloadFilter() & `createEntriesReadableStream(…
9018bf9 
…)` (#940)

- Removes `blobStore.download()` and the `LiveDownload` class.
- Adds `blobStore.createEntriesReadableStream()` which is a stream of
  all entries in the blob store, filtered by blob type and variant(s).
- Changes behaviour of `BlobStore` to auto-download blobs according to a
  `downloadFilter`.
- Changes the `BlobStore` filter according to `isArchiveDevice` setting.
- Changes the behaviour of `CoreManager` to not auto-download blob cores
  (this responsibility is now with `BlobStore`).

Closes [#681].

[#681]: #681

Co-authored-by: Evan Hahn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvanHahn EvanHahn

Labels
Project: Disk Space Management v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: blobStore.setDownloadFilter() & createEntriesReadableStream() digidem/comapeo-core
2 participants
@gmaclennan @EvanHahn