chore: upgrade Hyperdrive to 11.5.3, fix blob-store tests, fix hyperdrive blob namespace #151
Conversation
| @@ -266,7 +266,7 @@ class PretendCorestore { | |||
| ) | |||
| } else if (opts.name === 'db') { | |||
| return this.#coreManager.getWriterCore('blobIndex').core | |||
| } else if (opts.name === 'blobs') { | |||
| } else if (opts.name.includes('blobs')) { | |||
There was a problem hiding this comment.
this seems like a reasonable change but not sure how this works in practice. wanted to highlight in order to get clarity
There was a problem hiding this comment.
The blobs core in a hyperdrive is now indexed with ${this.db.core.id}/blobs rather than just blobs:
We don't know the id of that core at this stage so we check to see if blobs is in the core name.
It feels a little imprecise to use includes there, but if we somehow have other cores with blobs in their name we likely have other problems, too.
There was a problem hiding this comment.
We don't actually name any cores, so this will be fine. It's just a way of making sure we return the right core when hyperdrive asks for it. For existing hyperdrives it always reads the blob core key from the blob index anyway. In an ideal world the hyperdrive constructor would accept the blob core and the hyperbee core, but this is a necessary workaround for now.
This pr upgrades the hyperdrive package to latest and fixes a couple small errors:
Closes #147