fix: pin corestore dep to exact 6.8.4
#840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this with the latest release candidate https://github.com/digidem/comapeo-mobile/tree/0b8dd9f06aa7b0d28b4143ea3ad0b49c5c6af382 and things are working, e.g. the invite bug is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cause of bugs in the v1.0.0 release candidate. The
corestoredependency should have been pinned to the exact version that we are testing here (v6.8.4), but it was not.The mobile app had already been using
[email protected], which had changed the hypercore dep to[email protected]. This appeared to still work, to some extent. Commit digidem/comapeo-mobile@e06a7e4 included asrc/backend/package-lock.jsonchange that changed the corestore dep to[email protected]and its subdep to[email protected].Unfortunately we rely on hypercore internals, and in addition hypercore is not completely stable across minor versions, so changes to the hypercore version break things. We have thorough tests on comapeo-core to check that all the internals of hypercore that we depend on are tested and working, however the omission of pinning corestore resulted in a different version of hypercore being used in the mobile app.