chore: enable noUncheckedSideEffectImports TypeScript option
#861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should have no user impact. This updates TypeScript to the latest version, 5.6.2. It also updates `typedoc` dependencies to their latest versions. I verified that the generated types in `dist/` were not meaningfully changed. (Some `Iterator` types were slightly adjusted, as expected; [TypeScript 5.6 made some changes to how `Iterator` types work][0].) [0]: https://devblogs.microsoft.com/typescript/announcing-typescript-5-6/#iterator-helper-methods
This change should have no user impact. [`noUncheckedSideEffectImports`][0] checks side-effect imports, such as: ```typescript // Not actually importing anything from this module. import 'example' ``` This enables that option. No code changes were required; it may help avoid future mistakes. [0]: https://www.typescriptlang.org/tsconfig/#noUncheckedSideEffectImports
achou11
reviewed
Sep 24, 2024
EDIT: Nevermind, just saw that this depends on the other PR upgrading TypeScript |
achou11
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #860.
This change should have no user impact.
noUncheckedSideEffectImportschecks side-effect imports, such as:This enables that option.
No code changes were required; it may help avoid future mistakes.