Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out project members in useLocalPeers() hook #167

Closed
ximenabb opened this issue Jan 29, 2024 · 0 comments
Closed

Filter out project members in useLocalPeers() hook #167

ximenabb opened this issue Jan 29, 2024 · 0 comments
Assignees
Labels
MVP Needs to be completed for the initial QA release QA #1

Comments

@ximenabb
Copy link
Contributor

ximenabb commented Jan 29, 2024

Currently useLocalPeers() returns all connected devices, including devices that are already members of the current project. For the UX, a list of devices to invite to a project should not include devices that are already members of the project (this would lead to a confusing user experience - a user would try to invite a device, and receive a "already invited" response).

When rendering local peers, we need to also check the members of the project (project.$member.getMany()) and filter the members from the local peers array.

However, project membership can change while the user is viewing the screen, so ideally the list of project members should update in realtime. This is a follow-up task tracked in #170

@ximenabb ximenabb added the MVP Needs to be completed for the initial QA release label Jan 29, 2024
@ximenabb ximenabb added the QA #1 label Feb 8, 2024
@ErikSin ErikSin closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MVP Needs to be completed for the initial QA release QA #1
Projects
None yet
Development

No branches or pull requests

3 participants