Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a favorite store has been changed, it will no longer be available in favorites #1493

Open
seluianova opened this issue Jun 17, 2024 · 1 comment
Labels
blocked Task or user story can not be continued at the moment Task

Comments

@seluianova
Copy link
Contributor

seluianova commented Jun 17, 2024

Follow up to #1214

Is your feature request related to a problem? Please describe.
Because of the current implementation of data import, when we change any attributes of the acceptance store, we delete the old record in the database and create a new one with a new ID.
As a side effect, if a modified store has been saved as a favorite on some device, it will appear as "No longer available" to the user.
The user will have to delete it from favorites and save it again.

Describe the solution you'd like
Would be nice to get constant acceptance store ids from the upstream, instead of generating them on our side.

Describe alternatives you've considered
Perhaps we could treat some of the store attributes as constant (like name and coordinates?) and use them to compare data during the import.

Additional context
Add any other context or screenshots about the feature request here.

@f1sh1918
Copy link
Contributor

@seluianova i think this should be prio high, or we should disable the favorites by a feature flag until we fixed that. Should be discussed in the next weekly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Task or user story can not be continued at the moment Task
Projects
Status: No status
Development

No branches or pull requests

2 participants