Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1514: Use predefined platform git tag #1515

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Jun 27, 2024

Short description

Since we don't want to create git tags for all available platforms in a bump-up step in some scenarios, we have to pass a particular tags f.e. native | web | all depending on what release workflow we trigger.

Proposed changes

  • pass parameters for platform specific deployments
  • you can pass string separated by "/" for platforms f.e. web/native if you need

Dependency

depends on this pr to be merged
digitalfabrik/app-toolbelt#14

Side effects

  • none

Resolved issues

Fixes: #1514

Testing (dev only)

  1. (Before depending pr is merged) You can test it by replacing the following the repo url in install_app_toolbelt
    with: https://github.com/digitalfabrik/app-toolbelt/archive/refs/heads/bump-up-add-platform-option.tar.gz
  2. Choose a workflow that uses bump_version with prepare_delivery: true like deliver_beta_backend_administration but comment out all steps except bump_version
  3. trigger workflow
  4. Check for new git tag
    https://github.com/digitalfabrik/entitlementcard/tags

@f1sh1918 f1sh1918 force-pushed the 1514-use-prefefined-platform-git-tag branch from 227963d to edb9796 Compare June 27, 2024 09:20
@f1sh1918 f1sh1918 marked this pull request as ready for review June 27, 2024 09:35
@f1sh1918 f1sh1918 force-pushed the 1514-use-prefefined-platform-git-tag branch from 448b682 to b662050 Compare June 27, 2024 09:56
Copy link
Member

@ztefanie ztefanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, then toolbelt pr needs to be merged first.

@f1sh1918 f1sh1918 force-pushed the 1514-use-prefefined-platform-git-tag branch 3 times, most recently from 32be130 to 374c731 Compare July 23, 2024 11:52
@f1sh1918 f1sh1918 force-pushed the 1514-use-prefefined-platform-git-tag branch from e1288dc to 0de1500 Compare July 23, 2024 11:55
@f1sh1918 f1sh1918 enabled auto-merge July 23, 2024 11:57
@f1sh1918 f1sh1918 merged commit 18cf914 into main Jul 23, 2024
1 check passed
@f1sh1918 f1sh1918 deleted the 1514-use-prefefined-platform-git-tag branch July 23, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use predefined platform for git tag
2 participants