IGAPP-1372: Support RTL for POI Title on Map

[jira-to-github-migrator]

f1sh1918 - 7.8.2023, 10:08:48

As a user with a rtl language i would like to have the title of the pois displayed on the map

Acceptance Criteria

• Display the title of the poi in rtl language

 

Note:

• add arabic font glyphs to the mapstyles repo

https://github.com/digitalfabrik/integreat-maplibre-style

 

 

Environment: -
Linked issues:

[jira-to-github-migrator]

steffenkleinle - 9.8.2023, 14:25:56

<~andreas.fischer> is this ready/blocked/are you working on this?

f1sh1918 - 9.8.2023, 14:43:33

It's ready and no

[f1sh1918]

Hi @maxammann,

We would have to add arabic font-glyphs to support that feature.
Right now we included a submodule repo inside https://github.com/digitalfabrik/integreat-maplibre-style that doesn't have them.
What do you think about providing the glyphs by ourselfs?

Just found this repo for creating them: https://github.com/openmaptiles/fonts

just created a zip file with pbf that includes. So we could probably cover all languages
I think we can reduce the sources by the fonts we need to minimize the glyphs

  {
    "name": "Noto Sans Regular",
    "sources": [
      "NotoSans-Regular.ttf",
      "NotoNaskhArabic-Regular.ttf",
      "NotoSansArmenian-Regular.ttf",
      "NotoSansBalinese-Regular.ttf",
      "NotoSansBengali-Regular.ttf",
      "NotoSansCJKtc-Regular.otf",
      "NotoSansDevanagari-Regular.ttf",
      "NotoSansEthiopic-Regular.ttf",
      "NotoSansGeorgian-Regular.ttf",
      "NotoSansGujarati-Regular.ttf",
      "NotoSansGurmukhi-Regular.ttf",
      "NotoSansHebrew-Regular.ttf",
      "NotoSansJavanese-Regular.ttf",
      "NotoSansKannada-Regular.ttf",
      "NotoSansKhmer-Regular.ttf",
      "NotoSansLao-Regular.ttf",
      "NotoSansMongolian-Regular.ttf",
      "NotoSansMyanmar-Regular.ttf",
      "NotoSansOriya-Regular.ttf",
      "NotoSansSinhala-Regular.ttf",
      "NotoSansTamil-Regular.ttf",
      "NotoSansThai-Regular.ttf",
      "NotoSansTibetan-Regular.ttf",
      "//NotoSansTifinagh-Regular.ttf"
    ]
  },

Noto Sans Regular.zip

[maxammann]

We are currently using these fonts: https://github.com/orangemug/font-glyphs/tree/master

So preferably we adjust those.

Not sure which glyphs we need and how maplibre handles Arabic characters right now.

My guess is that it does not use the pbf font stacks for complex layout like arabic.

[f1sh1918]

ok. i think both libraries use fontnik and shouldn't have a big differences. Anyway we need to fork one of it and generate the glyphs we need. For me the repo i suggested looks way simpler and clearer to build pbf file for "Noto Sans Regular" out of different *.ttf's
You can easily configure which ttfs you want to use.
At least including more ttf increases the size of the pbf file so i think we should give it a try the ones we use in integreat
Noto Sans, Noto Sans Arabic, Noto Sans SC, Noto Sans Georgian

Noto Sans Regular_integreat_fonts.zip

General question is also why we want to provide all these unneeded glyphs within this submodule instead of just "Noto Sans Regular" @maxammann

Not sure if Noto Sans SC is supported

[f1sh1918]

i just added this pr on the mapstyle repo.
digitalfabrik/integreat-maplibre-style#15
I don't know why we should keep a 6 year old submodule dependency in our repo and all these unneeded glyphs @maxammann ?
If there is valid reason i'm gonna readd it

[maxammann]

i just added this pr on the mapstyle repo.
digitalfabrik/integreat-maplibre-style#15
I don't know why we should keep a 6 year old submodule dependency in our repo and all these unneeded glyphs @maxammann ?
If there is valid reason i'm gonna readd it

Both repos seem to do roughly the same thing. Both use fontnik to generate fonts for maplibre.

Switching fine, though make sure not to break paths used in the style Json.