Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUN-525: Wrong colored level #948

Closed
jira-to-github-migrator bot opened this issue Aug 13, 2023 · 2 comments
Closed

LUN-525: Wrong colored level #948

jira-to-github-migrator bot opened this issue Aug 13, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jira-to-github-migrator
Copy link

Martin Lehmann - 21.6.2023, 14:01:15

Expected Results:

level is marked green when passed fully successful

level is marked red  when passed partly successful (I believe)

level has no color when locked

Actual Results:

In some cases clolors are wrong

Steps to Reproduce:

  • I'm not able to reproduce this behavior nor know the reason

Environment: -
Linked issues:

@jira-to-github-migrator jira-to-github-migrator bot added the bug Something isn't working label Aug 13, 2023
@jira-to-github-migrator
Copy link
Author

LeandraH - 25.6.2023, 17:40:04

<~isabella.thang> Does Martin's summary of the colors look right to you, i.e. a green bar when the level was passed successfully, a red bar when it was passed poorly, and no color when it isn't unlocked yet? And should the first level (which you can't really fail, right?) have a color marking it?

Isabella Thang - 29.6.2023, 11:21:03

I've spend some several time to reproduce this: 
You can find the documentation here: https://www.figma.com/file/4bW33nU6zZ6ySeTqrM37Jq/Lunes_Master?type=design&node-id=1123%3A16786&mode=design&t=XmlRmOu2swMKZUgy-1 + screen recording attached

 

precon: 

  • Lernbereich: Schreiner:in und Tischler:in
  • Module: Dübel und Hobel 

summary of findings: 

  • the color marking seems fine to me for now
    • green: > 3 correct answers within 3 questionare rounds) -> user get access to the next level 
    • red: < 4 correct answers within 3 questionnaire rounds -> user has to repeat the level to get access to the next level 
  • counter implementation is somehow confusing (see documentation in Figma) 
    • counting starts with e.g. 1/11 and if 3 words are correctly answered -> counter shows 4/11
    • counter ist counting differently in round 3 than in round 1 and 2 within a module
  • other discoveries
    • for some words e.g. der Elektrohobel the right answer is not highlighted when answering wrong
    • it is not clear, when the words are repeating (round 1/2/3) atm

We should investigate some time to test it again and overthink the concept how and if we optimize this. Please let me know how we want to proceed here. 

steffenkleinle - 9.8.2023, 14:10:50

As the original issue is apparently not reproducible anymore, this should be rejected and split into new issues with the problems found by <~isabella.thang>.

@steffenkleinle steffenkleinle changed the title LUN-525: wrong colored level LUN-525: Wrong colored level Aug 29, 2023
@ztefanie
Copy link
Member

ztefanie commented Sep 5, 2023

Will close in favor of #993 and #992

@ztefanie ztefanie closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

1 participant