Implement stats fetch using dump-flows #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atistics for all matching flows in one shot. Also, provide an option to report interface names instead of port numbers, if requested.
do-msingh
force-pushed
the
msingh/dump-flow-stats
branch
from
e1c0033 to
b64fc3e
Compare
jcooperdo
reviewed
Oct 21, 2024
ovs/openflow.go
Outdated
| // DumpMatchingFlows retrieves statistics of all matching flows for the specified bridge. | ||
| // If a table has no active flows and has not been used for a lookup or matched | ||
| // by an incoming packet, it is filtered from the output. | ||
| func (o *OpenFlowService) DumpMatchingFlows(bridge string, flow *MatchFlow) ([]*Flow, error) { |
There was a problem hiding this comment.
Do we need DumpMatchingFlows? Does it provide any value that DumpFlowsWithFlowArgs doesn't already provide?
There was a problem hiding this comment.
Yeah, no real purpose, let me clean that up.
jcooperdo
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement stats fetch using dump-flows to provide an option to get statistics for all matching flows in one shot.
Also, provide an option to report interface names instead of port numbers, if requested.
This was also requested in #128