Duplicate "All" in Browse by Subject

[gerbie-goober]

Issue located in: find, stories
Issue: When clicking on the "Browse by Subject" tab, there are two "All" for the alphabetical filters. For the find site, clicking on one of them leads to a "Page not Found." For the stories site, clicking on either one of them selects all subjects.
Desired: Only one "All" shown.

Example:

• Reproduce issue on find site:

  • Click on the hamburger Menu icon on the Home page > Select "Browse by Subject" > Click on the first "All" filter
  • Should be led to this page: https://find.digital.utsc.utoronto.ca/browse-subjects

• Reproduce issue on stories site:

  • Click on the hamburger Menu icon on the Home page > Select "Browse by Subject" > Observe that there are two "All"s
  • note: clicking on either one performs as expected

[gerbie-goober]

Re: Duplicate "All" on stories site

• Issue was resolved by disabling JS Injector that added the "All" link
• This insight led us to discover that there is a theme being used that adds the "All" link in the block
• https://stories.digital.utsc.utoronto.ca/browse-subjects
• https://stories.digital.utsc.utoronto.ca/browse-people

Re: Duplicate "All" on find site

• Note: on this site, it is "Browse by Type" and not "Browse by Subject"
• Since this site also uses the theme that has JS script for the "All" (which has href attribute linking to "/browse-subjects"), the issue was temporarily fixed by removing that "All" link and replacing it with another "All" link of the same HTML structure but with a different link ("/browse-types")
• Please note the JS Injector being added: https://find.digital.utsc.utoronto.ca/admin/config/development/asset-injector/js/browse_by_types_replace_all_with_proper_link
  • Note: the styling of the temporary fix needs to be changed to fit the other links in the header
• https://find.digital.utsc.utoronto.ca/browse-types