Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix: Issue #346] Fixes for x-terraform-ignore-order #347

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[BugFix: Issue #346] Fixes for x-terraform-ignore-order #347

wants to merge 9 commits into from

Conversation

arjunrajinstaclustr
Copy link

What problem does this Pull Request solve?

Closes #346

Type of change

What type of change does your code introduce to the provider? Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

  • New feature (change that adds new functionality)
  • Bug-fix (change that fixes current functionality)
  • Tech debt (enhances the current functionality)
  • New release (pumps the version)

Checklist

Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

  • I have read and followed the CONTRIBUTING guidelines
  • I have added tests that prove my fix is effective or that my feature works
  • I have made sure code compiles correctly and all tests are passing by running make test-all
  • I have added/updated necessary documentation (if appropriate)
  • I have added the following info to the title of the PR (pick the appropriate option for the type of change). This is important because the release notes will include this information.
    • Feature Request: PRs related to feature requests should have in the title [FeatureRequest: Issue #X] <PR Title>
    • Bug Fixes: PRs related to bug fixes should have in the title [BugFix: Issue #X] <PR Title>
    • Tech Debt: PRs related to technical debt should have in the title [TechDebt: Issue #X] <PR Title>
    • New Release: PRs related to a new release should have in the title [NewRelease] vX.Y.Z

Checklist for Admins

  • Label is populated
  • PR is assigned to the corresponding project
  • PR has at least 1 reviewer and 1 assignee

@dikhan dikhan mentioned this pull request May 26, 2022
Closed
@dikhan
Copy link
Owner

dikhan commented May 26, 2022

Hey @arjunrajinstaclustr ,

Thanks for opening the issue and the PR! I will try to take a look at the changes sometime this week/next one (time permitting) and provide some feedback.

Dani

@arjunrajinstaclustr
Copy link
Author

Hi @dikhan , apologies if you're busy but any updates on this? Thanks!

@dikhan
Copy link
Owner

dikhan commented Jun 9, 2022 •
edited
Loading

Hey @arjunrajinstaclustr , sorry I was hoping to be able to look into this before my trip to Europe (family trip) but did not have a chance to. I want to review this PR very thoroughly as it's touching very sensitive areas in the code and want to confirm there's no regressions or breaking changes introduced; however I am not sure if I will be able to do so until I return back home in September.

As far as the build goes, it's currently failing due to to the ticket opened here: hashicorp/terraform#31135. I opened a ticket with Travis CI to see if they can update their Linux hosts with an up to date cert store, more info here: https://travis-ci.community/t/travis-ci-linux-hosts-certificate-store-not-up-to-date/13074

This was referenced Jun 9, 2022
Closed
Closed
@arjunrajinstaclustr
Copy link
Author

Thanks for the update @dikhan, much appreciated - will wait till you're back.

@arjunrajnetapp arjunrajnetapp mentioned this pull request Mar 29, 2023
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with x-terraform-ignore-order
2 participants
@arjunrajinstaclustr @dikhan