Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the Button on Create and Update forms #59

Open
phpMuhammed opened this issue Feb 12, 2020 · 10 comments
Open

Display the Button on Create and Update forms #59

phpMuhammed opened this issue Feb 12, 2020 · 10 comments

Comments

@phpMuhammed
Copy link

No description provided.

@phpMuhammed phpMuhammed changed the title Show Button on Create and Update forms Display the Button on Create and Update forms Feb 12, 2020
@CaddyDz
Copy link

CaddyDz commented Feb 16, 2020

You would think changing public property $showOnCreation on Button.php Line 22 to true would solve the issue but it doesn't

public $showOnCreation = true;

Doesn't do anything, still only shows on Detail screen

@bernhardh
Copy link
Contributor

Yeah, its a pitty, that this doesn't work.

@dillingham Any plans to make it work?

@CaddyDz
Copy link

CaddyDz commented Sep 24, 2020

You can use/check my fork, I didn't have time to turn it to a proper PR candidate
// @bernhardh

@bernhardh
Copy link
Contributor

bernhardh commented Sep 25, 2020

@CaddyDz Thanks for feedback. Maybe a stupid question, but how can I use your package? Its not on packagist, right?

I have added

    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/CaddyDz/nova-button.git"
        }
    ]

To my composer.json, but I still get the dillingham version?

@CaddyDz
Copy link

CaddyDz commented Sep 25, 2020

@bernhardh almost correct, replace "type": "git" by "type": "vcs" and make sure to place master as the version

@bernhardh
Copy link
Contributor

Thats not working. I think the reason is, that the dillingham master branch is "newer" then yours. He updated it 9 days ago. But thanks for your help, I have done another solution with the CustomEditHeader.vue

@dillingham
Copy link
Owner

@bernhardh sorry I've been slammed.. I'll try to get this added soon

@bernhardh
Copy link
Contributor

@dillingham: no problem.

I have now created a pull request with that feature plus moved code logic to mixin

@bernhardh
Copy link
Contributor

@dillingham: Would be really nice if you could merge this?

@kevinnivek
Copy link

@CaddyDz I just integrated your fork to replace this package and I am still not seeing the button on create/update forms

Button::make('BUTTON')->link('https://nova.laravel.com'),

Am I missing something?

dillingham added a commit that referenced this issue May 19, 2021
Display the Button on Create and Update forms #59
dnwjn added a commit to dnwjn/nova-button that referenced this issue Feb 6, 2022
dnwjn added a commit to dnwjn/nova-button that referenced this issue Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants