From 58e62bbfe424bacce209eb2578d5a128baf715c8 Mon Sep 17 00:00:00 2001 From: Michael Diamond Date: Sun, 6 Feb 2022 15:27:22 -0800 Subject: [PATCH] Remove flaky test workaround that doesn't work reliably. --- tests/cli.rs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/cli.rs b/tests/cli.rs index e1e9042..7d77b8b 100644 --- a/tests/cli.rs +++ b/tests/cli.rs @@ -199,6 +199,7 @@ mod cli { CmdResult { out: "2".into(), err: "".into(), status: Some(1) }); } + // Note: this test has been flaky in the past #[test] fn discard_failures_in_background() { let dir = TestDir::temp(); @@ -215,11 +216,6 @@ mod cli { // returns cached result, but attempts to warm in the background let last_mod = modtime(&file); make_dir_stale(dir.path("cache"), Duration::from_secs(15)).unwrap(); - assert_eq!(run(bkt(dir.path("cache")).args(&discard_stale_args)), - CmdResult { out: "1".into(), err: "".into(), status: Some(1) }); - // TODO this third call shouldn't be necessary, but for some reason the modtime assertion - // below fails occasionally even though the file contents check below that indicates the - // write happened. Other tests don't appear to trigger this race. assert_eq!(run(bkt(dir.path("cache")).args(&discard_stale_args)), CmdResult { out: "1".into(), err: "".into(), status: Some(1) }); @@ -229,7 +225,7 @@ mod cli { } // Command ran assert!(modtime(&file) > last_mod, "{:?} !> {:?}", modtime(&file), last_mod); - assert_eq!(std::fs::read_to_string(&file).unwrap(), "..."); + assert_eq!(std::fs::read_to_string(&file).unwrap(), ".."); // but cache was not updated assert_eq!(run(bkt(dir.path("cache")).args(&discard_args)),