Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island merge is O(N) #5

Open
jalberdi004 opened this issue Oct 9, 2018 · 2 comments
Open

Island merge is O(N) #5

jalberdi004 opened this issue Oct 9, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@jalberdi004
Copy link
Collaborator

Merging and counting the number of islands needs O(N), where N is the lattice size (=total number of lattice sites). There should be a way to count the islands iterating only the sites of merged islands.

Problematic method are countIslands() and computeDiffusivity() of AbstractGrowthLattice class.

@jalberdi004 jalberdi004 added the enhancement New feature or request label Oct 9, 2018
@jalberdi004
Copy link
Collaborator Author

Actually, it is not a big problem for a system size of 200x200. It is called roughly 130 times in 1e7 event. Every call needs around 6-7 ms, in total is less than 1s.

Those are test with the version 7f878cf and input
{ "automaticCollections": true, "calculationMode": "concerted", "cartSizeX": 200, "cartSizeY": 200, "coverage": 100, "depositionFlux": 1.0, "doIslandDiffusion": true, "doMultiAtomDiffusion": true, "forceNucleation": false, "justCentralFlake": false, "numberOfSimulations": 1, "outputData": false, "outputDataFormat": [ { "type": "extra" }, { "type": "aea" }, { "type": "mko" } ], "psd": false, "randomSeed": false, "ratesLibrary": "CuNi", "temperature": 55, "withGui": true, "numberOfSteps": 1e7, }

@jalberdi004
Copy link
Collaborator Author

The problem, which can be around 40% of the iteration time is the counting of the events (for the multiplicity study).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant