Merge pull request #15 from dipcode-software/feat/option-value-empty

Changed Select option to dont render value if it is empty

Author: srtab

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2.0.1] - 2017-12-11
+### Changed
+ - Loading `Twig` classes with psr-4 mode;
+ - Select `option` tag don't render `value` if it is empty.
+
 ## [2.0.0] - 2017-12-11
 ### Added
  - Documentation of package;

src/TemplatePacks/templates/default/select_option.html

@@ -1 +1 @@
-<option value="{{value|e}}"{% include 'attrs.html' with attrs %}>{{label|e}}</option>
+<option {% if value is not empty %}value="{{value|e}}"{% endif %}{% include 'attrs.html' with attrs %}>{{label|e}}</option>

tests/unit/Widgets/SelectTest.php

@@ -51,4 +51,21 @@ public function testRenderOtherSelected()
 
         $this->assertXmlStringEqualsXmlString($expected, $widget->render("name", "option3"));
     }
+
+    public function testRenderOptionWithouValue()
+    {
+        $widget = new Select([
+            "" => "",
+            "option2" => "option2",
+            "option3" => "option3",
+        ]);
+
+        $expected = '<select id="id_name" name="name">' .
+                        '<option></option>' .
+                        '<option value="option2">option2</option>' .
+                        '<option value="option3" selected="selected">option3</option>' .
+                    '</select>';
+
+        $this->assertXmlStringEqualsXmlString($expected, $widget->render("name", "option3"));
+    }
 }